[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAA8EJpok+M3xYqtKDM=N=+fc778ipUdYcnNBLLEXMkpNjjy5rQ@mail.gmail.com>
Date: Wed, 31 Jul 2024 02:34:58 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Bjorn Andersson <quic_bjorande@...cinc.com>
Cc: Abhinav Kumar <quic_abhinavk@...cinc.com>, freedreno@...ts.freedesktop.org,
Rob Clark <robdclark@...il.com>, Sean Paul <sean@...rly.run>,
Marijn Suijten <marijn.suijten@...ainline.org>, David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>, Abel Vesa <abel.vesa@...aro.org>,
Neil Armstrong <neil.armstrong@...aro.org>, dri-devel@...ts.freedesktop.org,
quic_jesszhan@...cinc.com, swboyd@...omium.org, dianders@...omium.org,
andersson@...nel.org, linux-arm-msm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drm/msm/dp: enable widebus on all relevant chipsets
On Wed, 31 Jul 2024 at 01:27, Bjorn Andersson <quic_bjorande@...cinc.com> wrote:
>
> On Tue, Jul 30, 2024 at 11:58:19PM +0300, Dmitry Baryshkov wrote:
> > Hi Abhinav,
> >
> > On Tue, 30 Jul 2024 at 22:50, Abhinav Kumar <quic_abhinavk@...cinc.com> wrote:
> > >
> > > Hardware document indicates that widebus is recommended on DP on all
> > > MDSS chipsets starting version 5.x.x and above.
> > >
> > > Follow the guideline and mark widebus support on all relevant
> > > chipsets for DP.
> > >
> > > Fixes: 766f705204a0 ("drm/msm/dp: Remove now unused connector_type from desc")
> > > Fixes: 1b2d98bdd7b7 ("drm/msm/dp: Add DisplayPort controller for SM8650")
> >
> > The issues are present in the following commits. Please consider using
> > them instead:
> >
> > Fixes: 757a2f36ab09 ("drm/msm/dp: enable widebus feature for display port")
> > Fixes: 1b2d98bdd7b7 ("drm/msm/dp: Add DisplayPort controller for SM8650")
> >
>
> But are we really fixing any bugs/issues here? While the docs do
> recommend widebus, we're effectively enabling more harware/features.
>
> Unless there's a strong reason (which I'm not confident that the commit
> message entails), I think we should drop the fixes-tags and just bring
> this to 6.12...
I'm fine either way. I'll check tomorrow if this is required to fix
https://gitlab.freedesktop.org/drm/msm/-/issues/43.
--
With best wishes
Dmitry
Powered by blists - more mailing lists