linux-kernel - Re: [PATCH v2] drm/msm/dp: enable widebus on all relevant chipsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7466dc92-15e9-40c9-a6ca-40fed44865ac@quicinc.com>
Date: Tue, 30 Jul 2024 16:50:02 -0700
From: Abhinav Kumar <quic_abhinavk@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Bjorn Andersson
	<quic_bjorande@...cinc.com>
CC: <freedreno@...ts.freedesktop.org>, Rob Clark <robdclark@...il.com>,
        "Sean
 Paul" <sean@...rly.run>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        "David Airlie" <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
        Abel
 Vesa <abel.vesa@...aro.org>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        <dri-devel@...ts.freedesktop.org>, <quic_jesszhan@...cinc.com>,
        <swboyd@...omium.org>, <dianders@...omium.org>, <andersson@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] drm/msm/dp: enable widebus on all relevant chipsets



On 7/30/2024 4:34 PM, Dmitry Baryshkov wrote:
> On Wed, 31 Jul 2024 at 01:27, Bjorn Andersson <quic_bjorande@...cinc.com> wrote:
>>
>> On Tue, Jul 30, 2024 at 11:58:19PM +0300, Dmitry Baryshkov wrote:
>>> Hi Abhinav,
>>>
>>> On Tue, 30 Jul 2024 at 22:50, Abhinav Kumar <quic_abhinavk@...cinc.com> wrote:
>>>>
>>>> Hardware document indicates that widebus is recommended on DP on all
>>>> MDSS chipsets starting version 5.x.x and above.
>>>>
>>>> Follow the guideline and mark widebus support on all relevant
>>>> chipsets for DP.
>>>>
>>>> Fixes: 766f705204a0 ("drm/msm/dp: Remove now unused connector_type from desc")
>>>> Fixes: 1b2d98bdd7b7 ("drm/msm/dp: Add DisplayPort controller for SM8650")
>>>
>>> The issues are present in the following commits. Please consider using
>>> them instead:
>>>
>>> Fixes: 757a2f36ab09 ("drm/msm/dp: enable widebus feature for display port")
>>> Fixes: 1b2d98bdd7b7 ("drm/msm/dp: Add DisplayPort controller for SM8650")
>>>
>>
>> But are we really fixing any bugs/issues here? While the docs do
>> recommend widebus, we're effectively enabling more harware/features.
>>
>> Unless there's a strong reason (which I'm not confident that the commit
>> message entails), I think we should drop the fixes-tags and just bring
>> this to 6.12...
> 
> I'm fine either way. I'll check tomorrow if this is required to fix
> https://gitlab.freedesktop.org/drm/msm/-/issues/43.
> 

In v1, I also did not have the Fixes tag and I admit, originally even 
though I made the change in an attempt to fix another issue, it was not 
resolving the issue completely so there is no functional issue getting 
fixed due to the change.

I have confirmed that on my setup this patch is not needed to fix that bug.

I decided to add the Fixes tag in v2 because not following the hw doc 
recommendation is also a bug as it can lead to unexplained issues. Thats 
why I am still divided on this.

If the consensus is not to take it as a fix, I am fine with it and will 
not include it and while we are compiling the changes for 6.12 this can 
be included without the Fixes tags.

> 
>