linux-kernel - Re: [PATCH] usb: gadget: f_fs: Define pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024073004-crinkly-lark-d9d1@gregkh>
Date: Tue, 30 Jul 2024 07:00:32 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Bjorn Andersson <quic_bjorande@...cinc.com>
Cc: linux-arm-msm@...r.kernel.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: f_fs: Define pr_fmt

On Mon, Jul 29, 2024 at 03:53:50PM -0700, Bjorn Andersson wrote:
> The majority of log entries of f_fs are generated with no indication of
> their origin. Prefix these, using pr_fmt, to make the kernel log
> clearer.
> 
> Signed-off-by: Bjorn Andersson <quic_bjorande@...cinc.com>
> ---
>  drivers/usb/gadget/function/f_fs.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c
> index d8b096859337..14ee43cb27b6 100644
> --- a/drivers/usb/gadget/function/f_fs.c
> +++ b/drivers/usb/gadget/function/f_fs.c
> @@ -10,6 +10,7 @@
>   * Copyright (C) 2003 Agilent Technologies
>   */
>  
> +#define pr_fmt(fmt) "f_fs: " fmt

Why not fix the driver up to use the proper dev_*() printing functions
instead?

Or, use KBUILD_MODNAME?

thanks,

greg k-h