linux-kernel - Re: [PATCH v2] char: misc: add missing #ifdef CONFIG_PROC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024073029-zippy-bats-ca30@gregkh>
Date: Tue, 30 Jul 2024 11:11:10 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: zhangjiao2 <zhangjiao2@...s.chinamobile.com>
Cc: arnd@...db.de, linux-kernel@...r.kernel.org, trivial@...nel.org
Subject: Re: [PATCH v2] char: misc: add missing #ifdef CONFIG_PROC_FS

On Tue, Jul 30, 2024 at 04:31:58PM +0800, zhangjiao2 wrote:
> From: Zhang Jiao <zhangjiao2@...s.chinamobile.com>
> 
> Since misc_seq_ops is defined under CONFIG_PROC_FS in this file,
> it also need under CONFIG_PROC_FS when use. 
> 
> >Again, why is a #ifdef ok in this .c file?  What changed to suddenly
> >require this?
> There is another #ifdef in this file, in there "misc_seq_ops" is defined.
> If CONFIG_PROC_FS is not defined, proc_create_seq is using an 
> undefined variable "misc_seq_ops", this may cause compile error.
> 

Why is this in the changelog text?

And what changed to suddenly require this proposed patch?  What commit
id does it fix?

confused,

greg k-h