linux-kernel - Re: [PATCH] [PATCH v2] wmi: Fix spelling mistakes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87bfdaa2-5b94-46b1-bbf7-d81245c7d658@gmx.de>
Date: Tue, 30 Jul 2024 14:25:30 +0200
From: Armin Wolf <W_Armin@....de>
To: Luis Felipe Hernandez <luis.hernandez093@...il.com>, corbet@....net
Cc: platform-driver-x86@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH] [PATCH v2] wmi: Fix spelling mistakes

Am 30.07.24 um 00:36 schrieb Luis Felipe Hernandez:

> There were a few instances of typos that could lead to confusion
> when reading. The following words have been corrected:
> Binay -> Binary
> singe -> single
> chaged -> changed

Hi,

please change the title to "platform/x86: msi-wmi-platform: Fix spelling mistakes".
With that being addressed:

Reviewed-by: Armin Wolf <W_Armin@....de>

> Signed-off-by: Luis Felipe Hernandez <luis.hernandez093@...il.com>
> ---
>   Documentation/wmi/devices/msi-wmi-platform.rst | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/wmi/devices/msi-wmi-platform.rst b/Documentation/wmi/devices/msi-wmi-platform.rst
> index 29b1b2e6d42c..31a136942892 100644
> --- a/Documentation/wmi/devices/msi-wmi-platform.rst
> +++ b/Documentation/wmi/devices/msi-wmi-platform.rst
> @@ -130,12 +130,12 @@ data using the `bmfdec <https://github.com/pali/bmfdec>`_ utility:
>
>   Due to a peculiarity in how Windows handles the ``CreateByteField()`` ACPI operator (errors only
>   happen when a invalid byte field is ultimately accessed), all methods require a 32 byte input
> -buffer, even if the Binay MOF says otherwise.
> +buffer, even if the Binary MOF says otherwise.
>
>   The input buffer contains a single byte to select the subfeature to be accessed and 31 bytes of
>   input data, the meaning of which depends on the subfeature being accessed.
>
> -The output buffer contains a singe byte which signals success or failure (``0x00`` on failure)
> +The output buffer contains a single byte which signals success or failure (``0x00`` on failure)
>   and 31 bytes of output data, the meaning if which depends on the subfeature being accessed.
>
>   WMI method Get_EC()
> @@ -147,7 +147,7 @@ data contains a flag byte and a 28 byte controller firmware version string.
>   The first 4 bits of the flag byte contain the minor version of the embedded controller interface,
>   with the next 2 bits containing the major version of the embedded controller interface.
>
> -The 7th bit signals if the embedded controller page chaged (exact meaning is unknown), and the
> +The 7th bit signals if the embedded controller page changed (exact meaning is unknown), and the
>   last bit signals if the platform is a Tigerlake platform.
>
>   The MSI software seems to only use this interface when the last bit is set.