linux-kernel - Re: [PATCH] arm: dts: arm: versatile-ab: Fix duplicate clock node name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47f60f74-27fc-4b69-b4ad-9d035c6732ea@roeck-us.net>
Date: Wed, 31 Jul 2024 08:14:29 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: "Rob Herring (Arm)" <robh@...nel.org>, soc@...nel.org,
 Linus Walleij <linus.walleij@...aro.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Sudeep Holla <sudeep.holla@....com>,
 Arnd Bergmann <arnd@...db.de>
Cc: linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm: dts: arm: versatile-ab: Fix duplicate clock node
 name

On 7/30/24 14:00, Rob Herring (Arm) wrote:
> Commit 04f08ef291d4 ("arm/arm64: dts: arm: Use generic clock and
> regulator nodenames") renamed nodes and created 2 "clock-24000000" nodes
> (at different paths). The kernel can't handle these duplicate names
> even though they are at different paths. Fix this by renaming one of
> the nodes to "clock-pclk". This name is aligned with other Arm boards
> (those didn't have a known frequency to use in the node name).
> 
> Fixes: 04f08ef291d4 ("arm/arm64: dts: arm: Use generic clock and regulator nodenames")
> Reported-by: Guenter Roeck <linux@...ck-us.net>
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>

Tested-by: Guenter Roeck <linux@...ck-us.net>

> ---
> Arnd, I imagine you can take this directly.
> 
>   arch/arm/boot/dts/arm/versatile-ab.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/arm/versatile-ab.dts b/arch/arm/boot/dts/arm/versatile-ab.dts
> index 6fe6b49f5d8e..635ab9268899 100644
> --- a/arch/arm/boot/dts/arm/versatile-ab.dts
> +++ b/arch/arm/boot/dts/arm/versatile-ab.dts
> @@ -157,7 +157,7 @@ timclk: clock-1000000 {
>   			clocks = <&xtal24mhz>;
>   		};
>   
> -		pclk: clock-24000000 {
> +		pclk: clock-pclk {
>   			#clock-cells = <0>;
>   			compatible = "fixed-factor-clock";
>   			clock-div = <1>;