linux-kernel - Re: [PATCH] arm: dts: arm: versatile-ab: Fix duplicate clock node name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdb1TbiMps0WLXZF4vu=RO71ubPUL9fB3DWO8axh4LOJmQ@mail.gmail.com>
Date: Fri, 2 Aug 2024 22:56:51 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: soc@...nel.org, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Sudeep Holla <sudeep.holla@....com>, Arnd Bergmann <arnd@...db.de>, Guenter Roeck <linux@...ck-us.net>, 
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm: dts: arm: versatile-ab: Fix duplicate clock node name

On Tue, Jul 30, 2024 at 11:01 PM Rob Herring (Arm) <robh@...nel.org> wrote:

> Commit 04f08ef291d4 ("arm/arm64: dts: arm: Use generic clock and
> regulator nodenames") renamed nodes and created 2 "clock-24000000" nodes
> (at different paths). The kernel can't handle these duplicate names
> even though they are at different paths. Fix this by renaming one of
> the nodes to "clock-pclk". This name is aligned with other Arm boards
> (those didn't have a known frequency to use in the node name).
>
> Fixes: 04f08ef291d4 ("arm/arm64: dts: arm: Use generic clock and regulator nodenames")
> Reported-by: Guenter Roeck <linux@...ck-us.net>
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>

Oh excellent, thanks.
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
Tested-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij