linux-kernel - Re: [PATCH v2] selftests: lib: remove strscpy test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2fb7e346-f49c-4a4a-812b-2b6d3c0edd25@linuxfoundation.org>
Date: Wed, 31 Jul 2024 12:13:11 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Muhammad Usama Anjum <usama.anjum@...labora.com>,
 Kees Cook <kees@...nel.org>
Cc: kernel@...labora.com, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org, Shuah Khan <shuah@...nel.org>,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2] selftests: lib: remove strscpy test

On 7/31/24 02:32, Muhammad Usama Anjum wrote:
> On 7/31/24 3:37 AM, Shuah Khan wrote:
>> On 7/25/24 06:11, Muhammad Usama Anjum wrote:
>>> The strscpy test loads test_strscpy module for testing. But test_strscpy
>>> was converted to Kunit (see fixes). Hence remove strscpy.
>>>
>>> Fixes: 41eefc46a3a4 ("string: Convert strscpy() self-test to KUnit")
>>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@...labora.com>
>>> ---
>>> Changes since v1:
>>> - Remove from Makefile and config file as well
>>> ---
>>
>> As mentioned in other threads on this conversion to kunit and removal
>> of kselfttest - NACK on this patch.
>>
>> Please don't send me any more of these conversion and removal patches.
> This patch is removing a dead kselftest as its corresponding test module
> was moved years ago (in 2022). This test has been failing since then. It
> seems like misunderstanding that I'm removing something.
> 


Thank you for the clarification

Applied linux-kselftest for Linux 6.12-rc1

thanks,
-- Shuah