linux-kernel - Re: [PATCH v2] selftests: lib: remove strscpy test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d26b317b-edda-4bb8-a022-912cd1f76b3a@collabora.com>
Date: Wed, 31 Jul 2024 13:32:48 +0500
From: Muhammad Usama Anjum <usama.anjum@...labora.com>
To: Shuah Khan <skhan@...uxfoundation.org>, Kees Cook <kees@...nel.org>
Cc: Muhammad Usama Anjum <usama.anjum@...labora.com>, kernel@...labora.com,
 linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
 Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH v2] selftests: lib: remove strscpy test

On 7/31/24 3:37 AM, Shuah Khan wrote:
> On 7/25/24 06:11, Muhammad Usama Anjum wrote:
>> The strscpy test loads test_strscpy module for testing. But test_strscpy
>> was converted to Kunit (see fixes). Hence remove strscpy.
>>
>> Fixes: 41eefc46a3a4 ("string: Convert strscpy() self-test to KUnit")
>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@...labora.com>
>> ---
>> Changes since v1:
>> - Remove from Makefile and config file as well
>> ---
> 
> As mentioned in other threads on this conversion to kunit and removal
> of kselfttest - NACK on this patch.
> 
> Please don't send me any more of these conversion and removal patches.
This patch is removing a dead kselftest as its corresponding test module
was moved years ago (in 2022). This test has been failing since then. It
seems like misunderstanding that I'm removing something.

> 
> thanks,
> -- Shuah
> 

-- 
BR,
Muhammad Usama Anjum