linux-kernel - Re: [PATCH 1/1] perf bpf: Move BPF disassembly routines to separate file to avoid clash with capstone bpf headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZqqHKWPcW3TvSQoQ@x1>
Date: Wed, 31 Jul 2024 15:49:13 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Namhyung Kim <namhyung@...nel.org>,
	linux-perf-users <linux-perf-users@...r.kernel.org>,
	Song Liu <song@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>,
	Jiri Olsa <jolsa@...nel.org>, Kan Liang <kan.liang@...ux.intel.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] perf bpf: Move BPF disassembly routines to separate
 file to avoid clash with capstone bpf headers

On Wed, Jul 31, 2024 at 10:35:12AM -0700, Ian Rogers wrote:
> On Wed, Jul 31, 2024 at 10:08 AM Namhyung Kim <namhyung@...nel.org> wrote:
> >
> > On Wed, Jul 31, 2024 at 8:12 AM Arnaldo Carvalho de Melo
> > <acme@...nel.org> wrote:
> [snip]
> > > +perf-util-y += disasm_bpf.o
> >
> > I think this can be gated by LIBBFD and LIBBPF config, but not sure
> > it can express the both requirements easily.
> 
> Should we gate things on libbfd? Given we can't distribute a binary
> linked against it, I support deleting all libbfd support. Fixes like
> this show the pain in carrying it.

I thought about it, but the problem at hand was that library A clashed
with library B for a namespace, so I fixed just that problem.

I agree that as soon as we reimplement the features that now are only
available with libbfd we should remove that code, now it is even more
isolated.

- Arnaldo