linux-kernel - Re: [PATCH v2] staging: rtl8723bs: Improve MAR register definition and usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <80076244-4d77-45d9-a721-06664e11477e@gmail.com>
Date: Wed, 31 Jul 2024 06:58:40 +0200
From: Philipp Hortmann <philipp.g.hortmann@...il.com>
To: Manjae Cho <manjae.cho@...sung.com>, gregkh@...uxfoundation.org
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: Improve MAR register definition
 and usage

On 7/31/24 01:10, Manjae Cho wrote:
> This patch improves the usage of the MAR register by updating the relevant
> macro definitions and ensuring consistent usage across the codebase.
> 
> Signed-off-by: Manjae Cho <manjae.cho@...sung.com>
> ---
> v2: Fix line length
> 
>   drivers/staging/rtl8723bs/include/hal_com_reg.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/include/hal_com_reg.h b/drivers/staging/rtl8723bs/include/hal_com_reg.h
> index baf326d53a46..93aa391fa749 100644
> --- a/drivers/staging/rtl8723bs/include/hal_com_reg.h
> +++ b/drivers/staging/rtl8723bs/include/hal_com_reg.h
> @@ -151,8 +151,8 @@
>   #define REG_BSSID						0x0618
>   #define REG_MAR							0x0620
>   
> -#define MAR0						REG_MAR		/* Multicast Address Register, Offset 0x0620-0x0623 */
> -#define MAR4						(REG_MAR + 4)	/* Multicast Address Register, Offset 0x0624-0x0627 */
> +#define MAR0		REG_MAR		/* Multicast Address Register, Offset 0x0620-0x0623 */
> +#define MAR4		(REG_MAR + 4)	/* Multicast Address Register, Offset 0x0624-0x0627 */
>   
>   #define REG_MAC_SPEC_SIFS				0x063A
>   /*  20100719 Joseph: Hardware register definition change. (HW datasheet v54) */

Hi Manjae,

this patch cannot be applied because you build it on top of your first 
patch which was not accepted. Please rebase this patch.

Thanks for your support.

Bye Philipp