linux-kernel - Re: [PATCH] staging: rtl8192e: remove duplicate macros from rtllib.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b53178f1-1b52-4fea-9edf-092e6961c96d@gmail.com>
Date: Wed, 31 Jul 2024 07:11:10 +0200
From: Philipp Hortmann <philipp.g.hortmann@...il.com>
To: Michael Straube <straube.linux@...il.com>, gregkh@...uxfoundation.org
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: remove duplicate macros from rtllib.h

On 7/30/24 10:29, Michael Straube wrote:
> These macros just duplicate macros from include/linux/ieee80211.h.
> We can safely remove them from rtllib.h.
> 
> Signed-off-by: Michael Straube <straube.linux@...il.com>
> ---
> compile-tested only
> 
>   drivers/staging/rtl8192e/rtllib.h | 11 -----------
>   1 file changed, 11 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
> index 022851b7f1a9..e87313a30741 100644
> --- a/drivers/staging/rtl8192e/rtllib.h
> +++ b/drivers/staging/rtl8192e/rtllib.h
> @@ -414,17 +414,6 @@ enum _REG_PREAMBLE_MODE {
>   #define WLAN_GET_SEQ_FRAG(seq) ((seq) & RTLLIB_SCTL_FRAG)
>   #define WLAN_GET_SEQ_SEQ(seq)  (((seq) & RTLLIB_SCTL_SEQ) >> 4)
>   
> -/* Authentication algorithms */
> -#define WLAN_AUTH_OPEN 0
> -#define WLAN_AUTH_SHARED_KEY 1
> -#define WLAN_AUTH_LEAP 128
> -
> -#define WLAN_CAPABILITY_ESS (1<<0)
> -#define WLAN_CAPABILITY_IBSS (1<<1)
> -#define WLAN_CAPABILITY_PRIVACY (1<<4)
> -#define WLAN_CAPABILITY_SHORT_PREAMBLE (1<<5)
> -#define WLAN_CAPABILITY_SHORT_SLOT_TIME (1<<10)
> -
>   #define RTLLIB_STATMASK_SIGNAL (1<<0)
>   #define RTLLIB_STATMASK_RSSI (1<<1)
>   #define RTLLIB_STATMASK_NOISE (1<<2)


Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com>