linux-kernel - Re: [PATCH] selftests: user: remove user suite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6d903772-2186-4d52-8391-df5ac2682b84@collabora.com>
Date: Wed, 31 Jul 2024 10:13:13 +0500
From: Muhammad Usama Anjum <usama.anjum@...labora.com>
To: Kees Cook <kees@...nel.org>, Shuah Khan <skhan@...uxfoundation.org>
Cc: Muhammad Usama Anjum <usama.anjum@...labora.com>, kernel@...labora.com,
 linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
 Shuah Khan <shuah@...nel.org>, David Gow <davidgow@...gle.com>,
 Vitor Massaru Iha <vitor@...saru.org>
Subject: Re: [PATCH] selftests: user: remove user suite

On 7/31/24 7:33 AM, Kees Cook wrote:
> 
> 
> On July 30, 2024 3:36:11 PM PDT, Shuah Khan <skhan@...uxfoundation.org> wrote:
>> On 7/25/24 08:44, Shuah Khan wrote:
>>> On 7/25/24 05:08, Muhammad Usama Anjum wrote:
>>>> The user test suite has only one test, test_user_copy which loads
>>>> test_user_copy module for testing. But test_user_copy module has already
>>>> been converted to kunit (see fixes). Hence remove the entire suite.
>>>>
>>>> Fixes: cf6219ee889f ("usercopy: Convert test_user_copy to KUnit test")
>>>
>>> Remove fixes tag - this isn't a fix and we don't want this propagating
>>> to stable releases without kunit test for this.
>>>
>>>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@...labora.com>
>>>> ---
>>>
>>> Thanks,
>>> -- Shuah
>>>
>>
>> As mentioned in other threads on this conversion to kunit and removal
>> of kselfttest - NACK on this patch.
>>
>> Please don't send me any more of these conversion and removal patches.
>>
> 
> I think there is a misunderstanding about these particular patches (for string and usercopy selftests). Those were already converted, as desired, by the maintainer (me) to KUnit. These associated patches are cleaning up the dangling kselftest part of them, and should land (with the Fixes tag, which is aimed at the commit that did the conversion).
Yes, this is misunderstanding and these patches should be taken to remove
dead tests in kselftests as their corresponding test modules have been
moved already. So these patches are fixes.

> 
> -Kees
> 
> 

-- 
BR,
Muhammad Usama Anjum