linux-kernel - Re: [PATCH v3 2/2] media: imx335: Fix reset-gpio handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e6c24c2-bdf3-4c44-8447-ca61e0e3e06b@kernel.org>
Date: Wed, 31 Jul 2024 09:29:30 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Umang Jain <umang.jain@...asonboard.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, "Paul J. Murphy"
 <paul.j.murphy@...el.com>,
 Daniele Alessandrelli <daniele.alessandrelli@...el.com>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Martina Krasteva <martinax.krasteva@...el.com>
Cc: linux-media@...r.kernel.org, devicetree@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org,
 Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
 Kieran Bingham <kieran.bingham@...asonboard.com>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>, stable@...r.kernel.org
Subject: Re: [PATCH v3 2/2] media: imx335: Fix reset-gpio handling

On 31/07/2024 09:02, Umang Jain wrote:
> Rectify the logical value of reset-gpio so that it is set to
> 0 (disabled) during power-on and to 1 (enabled) during power-off.
> 
> Meanwhile at it, set the reset-gpio to GPIO_OUT_HIGH at initialization
> time to make sure it starts off in reset. Also drop the "Set XCLR"
> comment which is not-so-informative.
> 

None of our conclusions are explained, which I requested.

Best regards,
Krzysztof