linux-kernel - Re: [PATCH v3 1/2] dt-bindings: media: imx335: Add reset-gpios to the DT example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8da6c3bf-05a5-41a9-8f3d-0b8c6495bef1@kernel.org>
Date: Wed, 31 Jul 2024 09:32:13 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Umang Jain <umang.jain@...asonboard.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, "Paul J. Murphy"
 <paul.j.murphy@...el.com>,
 Daniele Alessandrelli <daniele.alessandrelli@...el.com>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Martina Krasteva <martinax.krasteva@...el.com>
Cc: linux-media@...r.kernel.org, devicetree@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org,
 Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
 Kieran Bingham <kieran.bingham@...asonboard.com>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: media: imx335: Add reset-gpios to the
 DT example

On 31/07/2024 09:02, Umang Jain wrote:
> It's easy to get the polarity of GPIOs in the device tree wrong, as
> shown by a recently fixed bug in the imx335 driver. To lower the chance
> of future mistakes, especially in new bindings that would take the
> imx335 binding as a starting point, add the reset-gpios property to the
> DT example. This showcases the correct polarity of the XCLR signal for
> Sony sensors in the most common case of the signal not being inverted on
> the board.
> 

Just one sentence like - make the example complete by adding reset-gpios
with proper polarity - would be enough. Concise, yet still informative,
commit msgs are preferred, usually.

This device is not different than 1000 others which use GPIOs and for
every device you must use proper polarity. Commit msg suggests that here
we should explain something more.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof