linux-kernel - Re: [PATCH] kunit: Device wrappers should also manage driver name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <938af9c931203f2d2cba5332be3e530b@kernel.org>
Date: Wed, 31 Jul 2024 08:34:58 +0000
From: "Maxime Ripard" <mripard@...nel.org>
To: "David Gow" <davidgow@...gle.com>
Cc: kunit-dev@...glegroups.com, linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org, "Brendan
 Higgins" <brendan.higgins@...ux.dev>, "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>, "Kees
 Cook" <kees@...nel.org>, "Matti Vaittinen" <mazziesaccount@...il.com>, "Maxime
 Ripard" <mripard@...nel.org>, "Nico Pache" <npache@...hat.com>, "Rae Moar" <rmoar@...gle.com>, "Shuah
 Khan" <skhan@...uxfoundation.org>
Subject: Re: [PATCH] kunit: Device wrappers should also manage driver name

On Wed, 31 Jul 2024 15:02:06 +0800, David Gow wrote:
> kunit_driver_create() accepts a name for the driver, but does not copy
> it, so if that name is either on the stack, or otherwise freed, we end
> up with a use-after-free when the driver is cleaned up.
> 
> Instead, strdup() the name, and manage it as another KUnit allocation.
> 
> [ ... ]

Reviewed-by: Maxime Ripard <mripard@...nel.org>

Thanks!
Maxime