linux-kernel - Re: [PATCH v12 11/24] virt: geniezone: Add ioeventfd support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240731085739.GO1967603@kernel.org>
Date: Wed, 31 Jul 2024 09:57:39 +0100
From: Simon Horman <horms@...nel.org>
To: Liju-clr Chen <liju-clr.chen@...iatek.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Jonathan Corbet <corbet@....net>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will@...nel.org>, Steven Rostedt <rostedt@...dmis.org>,
	Masami Hiramatsu <mhiramat@...nel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Richard Cochran <richardcochran@...il.com>,
	Matthias Brugger <matthias.bgg@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Yingshiuan Pan <Yingshiuan.Pan@...iatek.com>,
	Ze-yu Wang <Ze-yu.Wang@...iatek.com>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-trace-kernel@...r.kernel.org, netdev@...r.kernel.org,
	linux-mediatek@...ts.infradead.org,
	Shawn Hsiao <shawn.hsiao@...iatek.com>,
	PeiLun Suei <PeiLun.Suei@...iatek.com>,
	Chi-shen Yeh <Chi-shen.Yeh@...iatek.com>,
	Kevenny Hsieh <Kevenny.Hsieh@...iatek.com>
Subject: Re: [PATCH v12 11/24] virt: geniezone: Add ioeventfd support

On Tue, Jul 30, 2024 at 04:24:23PM +0800, Liju-clr Chen wrote:
> From: Yingshiuan Pan <yingshiuan.pan@...iatek.com>
> 
> Ioeventfd leverages eventfd to provide asynchronous notification
> mechanism for VMM. VMM can register a mmio address and bind with an
> eventfd. Once a mmio trap occurs on this registered region, its
> corresponding eventfd will be notified.
> 
> Signed-off-by: Yingshiuan Pan <yingshiuan.pan@...iatek.com>
> Signed-off-by: Yi-De Wu <yi-de.wu@...iatek.com>
> Signed-off-by: Liju Chen <liju-clr.chen@...iatek.com>

...

> diff --git a/drivers/virt/geniezone/gzvm_ioeventfd.c b/drivers/virt/geniezone/gzvm_ioeventfd.c

...

> +/**
> + * ioeventfd_check_collision() - Check collison assumes gzvm->ioevent_lock held.

nit: collision

     Likewise elsewhere in this patch.

     Flagged by checkpatch.pl --codespell

> + * @gzvm: Pointer to gzvm.
> + * @p: Pointer to gzvm_ioevent.
> + *
> + * Return:
> + * * true			- collison found
> + * * false			- no collison
> + */

...