linux-kernel - Re: [PATCH v1 1/1] mfd: rk8xx: Fix shutdown handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ih7hiojzuvqzpyipj66mgu5pmcderltabim7s5dnfzm6qpztbh@jqkst5tfw5ra>
Date: Thu, 1 Aug 2024 17:22:24 +0200
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Lee Jones <lee@...nel.org>
Cc: Dmitrii Osipenko <dmitry.osipenko@...labora.com>, 
	Mark Brown <broonie@...nel.org>, Urja <urja@...a.dev>, Heiko Stuebner <heiko@...ech.de>, 
	linux-rockchip@...ts.infradead.org, linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org, 
	kernel@...labora.com, stable@...r.kernel.org
Subject: Re: [PATCH v1 1/1] mfd: rk8xx: Fix shutdown handler

Hello Lee,

On Thu, Aug 01, 2024 at 02:18:23PM GMT, Lee Jones wrote:
> > +	/*
> > +	 * Currently the Rockchip SPI driver always sleeps when doing SPI
> > +	 * transfers. This is not allowed in the SYS_OFF_MODE_POWER_OFF
> > +	 * handler, so we are using the prepare handler as a workaround.
> > +	 * This should be removed once the Rockchip SPI driver has been
> > +	 * adapted.
> > +	 */
> 
> So why not just adapt the SPI driver now?

This patch is simple and thus can easily be backported, so that the
Acer Chromebook shutdown is fixed in the stable kernels. SPI based
rkxx has been using SYS_OFF_MODE_POWER_OFF_PREPARE from the start,
so it's not a regression.

As far as I could see the SPI framework does not have something
comparable to the I2C .xfer_atomic handler. So fixing up the
Rockchip SPI driver probably involves creating some SPI core
helpers. I'm not yet sure about the best way to deal with this.
But I guess it will be better not having to backport all of the
requires changes to stable.

In any case I think the next step in this direction is discussing
how to handle this in general for SPI.

> What's the bet that if accepted, this hack is still here in 5 years time?

Even if I don't work on this now, I would expect somebody to have
issues with broken shutdown on RK3588 boards before 5 years are
over :)

Greetings,

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)