linux-kernel - Re: [PATCH v1 1/1] mfd: rk8xx: Fix shutdown handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4d6da27-3b23-4a96-bad0-17f2392287ef@collabora.com>
Date: Thu, 1 Aug 2024 18:31:33 +0300
From: Dmitry Osipenko <dmitry.osipenko@...labora.com>
To: Sebastian Reichel <sebastian.reichel@...labora.com>,
 Lee Jones <lee@...nel.org>
Cc: Mark Brown <broonie@...nel.org>, Urja <urja@...a.dev>,
 Heiko Stuebner <heiko@...ech.de>, linux-rockchip@...ts.infradead.org,
 linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
 kernel@...labora.com, stable@...r.kernel.org
Subject: Re: [PATCH v1 1/1] mfd: rk8xx: Fix shutdown handler

On 7/30/24 21:05, Sebastian Reichel wrote:
> +	/*
> +	 * Currently the Rockchip SPI driver always sleeps when doing SPI
> +	 * transfers. This is not allowed in the SYS_OFF_MODE_POWER_OFF
> +	 * handler, so we are using the prepare handler as a workaround.
> +	 * This should be removed once the Rockchip SPI driver has been
> +	 * adapted.
> +	 */
> +	if (is_spi)
> +		pwr_off_mode = SYS_OFF_MODE_POWER_OFF_PREPARE;

This prevents the syscore_shutdown() step from execution. Is it better
than not powering off?

I'd rather skip registration of the power-off handlers in a case of SPI :)

-- 
Best regards,
Dmitry