[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zqu3aHJzAnb3KDvz@shell.armlinux.org.uk>
Date: Thu, 1 Aug 2024 17:27:20 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
andrew@...n.ch, horms@...nel.org, hkallweit1@...il.com,
richardcochran@...il.com, rdunlap@...radead.org,
Bryan.Whitehead@...rochip.com, edumazet@...gle.com,
pabeni@...hat.com, linux-kernel@...r.kernel.org,
UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH net-next V3 3/4] net: lan743x: Migrate phylib to phylink
On Thu, Aug 01, 2024 at 04:33:13PM +0530, Raju Lakkaraju wrote:
> > > + if (!dn || (ret && !lan743x_phy_handle_exists(dn))) {
> > > + phydev = phy_find_first(adapter->mdiobus);
> > > + if (!phydev) {
> > > + if (((adapter->csr.id_rev & ID_REV_ID_MASK_) ==
> > > + ID_REV_ID_LAN7431_) || adapter->is_pci11x1x) {
> > > + phydev = fixed_phy_register(PHY_POLL,
> > > + &fphy_status,
> > > + NULL);
> >
> > I thought something was going to happen with this?
>
> Our SQA confirmed that it's working ping as expected (i.e Speed at 1Gbps
> with full duplex) with Intel I210 NIC as link partner.
>
> Do you suspect any corner case where it's fail?
Let me restate the review comment from V2:
"Eww. Given that phylink has its own internal fixed-PHY support, can we
not find some way to avoid the legacy fixed-PHY usage here?"
Yes, it may work, but fixed-phy is not supposed to be used with phylink.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Powered by blists - more mailing lists