linux-kernel - Re: [PATCH net-next 6/6] net: netconsole: Defer netpoll cleanup to avoid lock release during list traversal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zqu3z0YyhCgL+VFi@gmail.com>
Date: Thu, 1 Aug 2024 09:29:03 -0700
From: Breno Leitao <leitao@...ian.org>
To: Stephen Hemminger <stephen@...workplumber.org>
Cc: kuba@...nel.org, davem@...emloft.net, edumazet@...gle.com,
	pabeni@...hat.com, thevlad@...com, thepacketgeek@...il.com,
	riel@...riel.com, horms@...nel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, paulmck@...nel.org,
	davej@...emonkey.org.uk
Subject: Re: [PATCH net-next 6/6] net: netconsole: Defer netpoll cleanup to
 avoid lock release during list traversal

Hello Stephen,

On Thu, Aug 01, 2024 at 09:21:56AM -0700, Stephen Hemminger wrote:
> On Thu,  1 Aug 2024 09:12:03 -0700
> Breno Leitao <leitao@...ian.org> wrote:
> 
> > diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
> > index eb9799edb95b..dd984ee4a564 100644
> > --- a/drivers/net/netconsole.c
> > +++ b/drivers/net/netconsole.c
> > @@ -37,6 +37,7 @@
> >  #include <linux/configfs.h>
> >  #include <linux/etherdevice.h>
> >  #include <linux/utsname.h>
> > +#include <linux/rtnetlink.h>
> >  
> >  MODULE_AUTHOR("Maintainer: Matt Mackall <mpm@...enic.com>");
> 
> Should the Maintainer part be removed from the AUTHOR string by now?

Yes, I think this is a good idea. I will send a patch soon.

--breno