linux-kernel - Re: [PATCH v3 04/26] MIPS: sgi-ip27: drop HAVE_ARCH_NODEDATA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240801184546.00000ba6@Huawei.com>
Date: Thu, 1 Aug 2024 18:45:46 +0100
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Mike Rapoport <rppt@...nel.org>
CC: <linux-kernel@...r.kernel.org>, Alexander Gordeev
	<agordeev@...ux.ibm.com>, Andreas Larsson <andreas@...sler.com>, "Andrew
 Morton" <akpm@...ux-foundation.org>, Arnd Bergmann <arnd@...db.de>, "Borislav
 Petkov" <bp@...en8.de>, Catalin Marinas <catalin.marinas@....com>, Christophe
 Leroy <christophe.leroy@...roup.eu>, Dan Williams <dan.j.williams@...el.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>, David Hildenbrand
	<david@...hat.com>, "David S. Miller" <davem@...emloft.net>, Davidlohr Bueso
	<dave@...olabs.net>, "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>, Heiko
 Carstens <hca@...ux.ibm.com>, Huacai Chen <chenhuacai@...nel.org>, Ingo
 Molnar <mingo@...hat.com>, Jiaxun Yang <jiaxun.yang@...goat.com>, "John Paul
 Adrian Glaubitz" <glaubitz@...sik.fu-berlin.de>, Jonathan Corbet
	<corbet@....net>, Michael Ellerman <mpe@...erman.id.au>, Palmer Dabbelt
	<palmer@...belt.com>, "Rafael J. Wysocki" <rafael@...nel.org>, Rob Herring
	<robh@...nel.org>, Samuel Holland <samuel.holland@...ive.com>, Thomas
 Bogendoerfer <tsbogend@...ha.franken.de>, Thomas Gleixner
	<tglx@...utronix.de>, "Vasily Gorbik" <gor@...ux.ibm.com>, Will Deacon
	<will@...nel.org>, Zi Yan <ziy@...dia.com>, <devicetree@...r.kernel.org>,
	<linux-acpi@...r.kernel.org>, <linux-arch@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-cxl@...r.kernel.org>,
	<linux-doc@...r.kernel.org>, <linux-mips@...r.kernel.org>,
	<linux-mm@...ck.org>, <linux-riscv@...ts.infradead.org>,
	<linux-s390@...r.kernel.org>, <linux-sh@...r.kernel.org>,
	<linuxppc-dev@...ts.ozlabs.org>, <loongarch@...ts.linux.dev>,
	<nvdimm@...ts.linux.dev>, <sparclinux@...r.kernel.org>, <x86@...nel.org>
Subject: Re: [PATCH v3 04/26] MIPS: sgi-ip27: drop
 HAVE_ARCH_NODEDATA_EXTENSION

On Thu,  1 Aug 2024 09:08:04 +0300
Mike Rapoport <rppt@...nel.org> wrote:

> From: "Mike Rapoport (Microsoft)" <rppt@...nel.org>
> 
> Commit f8f9f21c7848 ("MIPS: Fix build error for loongson64 and
> sgi-ip27") added HAVE_ARCH_NODEDATA_EXTENSION to sgi-ip27 to silence a
> compilation error that happened because sgi-ip27 didn't define array of
> pg_data_t as node_data like most other architectures did.
> 
> After addition of node_data array that matches other architectures and
> after ensuring that offline nodes do not appear on node_possible_map, it
> is safe to drop arch_alloc_nodedata() and HAVE_ARCH_NODEDATA_EXTENSION
> from sgi-ip27.
> 
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@...nel.org>

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

> ---
>  arch/mips/Kconfig                |  1 -
>  arch/mips/sgi-ip27/ip27-memory.c | 10 ----------
>  2 files changed, 11 deletions(-)
> 
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 60077e576935..ea5f3c3c31f6 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -735,7 +735,6 @@ config SGI_IP27
>  	select WAR_R10000_LLSC
>  	select MIPS_L1_CACHE_SHIFT_7
>  	select NUMA
> -	select HAVE_ARCH_NODEDATA_EXTENSION
>  	help
>  	  This are the SGI Origin 200, Origin 2000 and Onyx 2 Graphics
>  	  workstations.  To compile a Linux kernel that runs on these, say Y
> diff --git a/arch/mips/sgi-ip27/ip27-memory.c b/arch/mips/sgi-ip27/ip27-memory.c
> index c30ef6958b97..eb6d2fa41a8a 100644
> --- a/arch/mips/sgi-ip27/ip27-memory.c
> +++ b/arch/mips/sgi-ip27/ip27-memory.c
> @@ -426,13 +426,3 @@ void __init mem_init(void)
>  	memblock_free_all();
>  	setup_zero_pages();	/* This comes from node 0 */
>  }
> -
> -pg_data_t * __init arch_alloc_nodedata(int nid)
> -{
> -	return memblock_alloc(sizeof(pg_data_t), SMP_CACHE_BYTES);
> -}
> -
> -void arch_refresh_nodedata(int nid, pg_data_t *pgdat)
> -{
> -	__node_data[nid] = (struct node_data *)pgdat;
> -}