linux-kernel - Re: [PATCH 08/10] serial: rp2: Remove deprecated PCI functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6eb427a501499273b39439dd6514fef399c3b55f.camel@redhat.com>
Date: Fri, 02 Aug 2024 09:39:11 +0200
From: Philipp Stanner <pstanner@...hat.com>
To: Jiri Slaby <jirislaby@...nel.org>, Jonathan Corbet <corbet@....net>, 
 Damien Le Moal <dlemoal@...nel.org>, Niklas Cassel <cassel@...nel.org>,
 Giovanni Cabiddu <giovanni.cabiddu@...el.com>, Herbert Xu
 <herbert@...dor.apana.org.au>,  "David S. Miller" <davem@...emloft.net>,
 Boris Brezillon <bbrezillon@...nel.org>, Arnaud Ebalard
 <arno@...isbad.org>,  Srujana Challa <schalla@...vell.com>, Alexander
 Shishkin <alexander.shishkin@...ux.intel.com>, Miri Korenblit
 <miriam.rachel.korenblit@...el.com>, Kalle Valo <kvalo@...nel.org>, Serge
 Semin <fancer.lancer@...il.com>, Jon Mason <jdmason@...zu.us>, Dave Jiang
 <dave.jiang@...el.com>, Allen Hubbe <allenbh@...il.com>, Bjorn Helgaas
 <bhelgaas@...gle.com>, Kevin Cernekee <cernekee@...il.com>, Greg
 Kroah-Hartman <gregkh@...uxfoundation.org>, Jaroslav Kysela
 <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, Mark Brown
 <broonie@...nel.org>, David Lechner <dlechner@...libre.com>, Uwe
 Kleine-König <u.kleine-koenig@...gutronix.de>, Jonathan
 Cameron <Jonathan.Cameron@...wei.com>,  Andy Shevchenko
 <andriy.shevchenko@...ux.intel.com>, Jie Wang <jie.wang@...el.com>, Adam
 Guerin <adam.guerin@...el.com>, Shashank Gupta <shashank.gupta@...el.com>,
 Damian Muszynski <damian.muszynski@...el.com>, Nithin Dabilpuram
 <ndabilpuram@...vell.com>, Bharat Bhushan <bbhushan2@...vell.com>, Johannes
 Berg <johannes.berg@...el.com>, Gregory Greenman
 <gregory.greenman@...el.com>, Emmanuel Grumbach
 <emmanuel.grumbach@...el.com>, Yedidya Benshimol
 <yedidya.ben.shimol@...el.com>, Breno Leitao <leitao@...ian.org>, Ilpo
 Järvinen <ilpo.jarvinen@...ux.intel.com>, John Ogness
 <john.ogness@...utronix.de>, Thomas Gleixner <tglx@...utronix.de>
Cc: linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, 
 linux-ide@...r.kernel.org, qat-linux@...el.com,
 linux-crypto@...r.kernel.org,  linux-wireless@...r.kernel.org,
 ntb@...ts.linux.dev, linux-pci@...r.kernel.org, 
 linux-serial@...r.kernel.org, linux-sound@...r.kernel.org
Subject: Re: [PATCH 08/10] serial: rp2: Remove deprecated PCI functions

On Fri, 2024-08-02 at 07:18 +0200, Jiri Slaby wrote:
> On 01. 08. 24, 19:46, Philipp Stanner wrote:
> > pcim_iomap_table() and pcim_iomap_regions_request_all() have been
> > deprecated by the PCI subsystem in commit e354bb84a4c1 ("PCI:
> > Deprecate
> > pcim_iomap_table(), pcim_iomap_regions_request_all()").
> > 
> > Replace these functions with their successors, pcim_iomap() and
> > pcim_request_all_regions()
> 
> Reviewed-by: Jiri Slaby <jirislaby@...nel.org>

Thank you for the review.

I have to provide a v2 for a small bug in one of the other patches.
While I'm at it, I would rename the title of this patch №8 here so that
it's "Replace" instead of "Remove", making it consistent with the other
ones.

I'd assume that keeping your RB then would be alright. Please tell me
if not.

Cheers,
P.

> 
> > Signed-off-by: Philipp Stanner <pstanner@...hat.com>
> > ---
> >   drivers/tty/serial/rp2.c | 12 +++++++-----
> >   1 file changed, 7 insertions(+), 5 deletions(-)
> 
> thanks,