linux-kernel - Re: [PATCH 09/10] ALSA: korg1212: Replace deprecated PCI functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ed77ic93.wl-tiwai@suse.de>
Date: Fri, 02 Aug 2024 10:02:00 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Philipp Stanner <pstanner@...hat.com>
Cc: Jonathan Corbet <corbet@....net>,	Damien Le Moal <dlemoal@...nel.org>,
	Niklas Cassel <cassel@...nel.org>,	Giovanni Cabiddu
 <giovanni.cabiddu@...el.com>,	Herbert Xu <herbert@...dor.apana.org.au>,
	"David S. Miller" <davem@...emloft.net>,	Boris Brezillon
 <bbrezillon@...nel.org>,	Arnaud Ebalard <arno@...isbad.org>,	Srujana Challa
 <schalla@...vell.com>,	Alexander Shishkin
 <alexander.shishkin@...ux.intel.com>,	Miri Korenblit
 <miriam.rachel.korenblit@...el.com>,	Kalle Valo <kvalo@...nel.org>,	Serge
 Semin <fancer.lancer@...il.com>,	Jon Mason <jdmason@...zu.us>,	Dave Jiang
 <dave.jiang@...el.com>,	Allen Hubbe <allenbh@...il.com>,	Bjorn Helgaas
 <bhelgaas@...gle.com>,	Kevin Cernekee <cernekee@...il.com>,	Greg
 Kroah-Hartman <gregkh@...uxfoundation.org>,	Jiri Slaby
 <jirislaby@...nel.org>,	Jaroslav Kysela <perex@...ex.cz>,	Takashi Iwai
 <tiwai@...e.com>,	Mark Brown <broonie@...nel.org>,	David Lechner
 <dlechner@...libre.com>,	Uwe Kleine-König
 <u.kleine-koenig@...gutronix.de>,	Jonathan Cameron
 <Jonathan.Cameron@...wei.com>,	Andy Shevchenko
 <andriy.shevchenko@...ux.intel.com>,	Jie Wang <jie.wang@...el.com>,	Adam
 Guerin <adam.guerin@...el.com>,	Shashank Gupta <shashank.gupta@...el.com>,
	Damian Muszynski <damian.muszynski@...el.com>,	Nithin Dabilpuram
 <ndabilpuram@...vell.com>,	Bharat Bhushan <bbhushan2@...vell.com>,	Johannes
 Berg <johannes.berg@...el.com>,	Gregory Greenman
 <gregory.greenman@...el.com>,	Emmanuel Grumbach
 <emmanuel.grumbach@...el.com>,	Yedidya Benshimol
 <yedidya.ben.shimol@...el.com>,	Breno Leitao <leitao@...ian.org>,	Ilpo
 Järvinen <ilpo.jarvinen@...ux.intel.com>,	John Ogness
 <john.ogness@...utronix.de>,	Thomas Gleixner <tglx@...utronix.de>,
	linux-doc@...r.kernel.org,	linux-kernel@...r.kernel.org,
	linux-ide@...r.kernel.org,	qat-linux@...el.com,
	linux-crypto@...r.kernel.org,	linux-wireless@...r.kernel.org,
	ntb@...ts.linux.dev,	linux-pci@...r.kernel.org,
	linux-serial@...r.kernel.org,	linux-sound@...r.kernel.org
Subject: Re: [PATCH 09/10] ALSA: korg1212: Replace deprecated PCI functions

On Thu, 01 Aug 2024 19:46:07 +0200,
Philipp Stanner wrote:
> 
> pcim_iomap_table() and pcim_iomap_regions_request_all() have been
> deprecated by the PCI subsystem in commit e354bb84a4c1 ("PCI: Deprecate
> pcim_iomap_table(), pcim_iomap_regions_request_all()").
> 
> Replace these functions with their successors, pcim_iomap() and
> pcim_request_all_regions()
> 
> Signed-off-by: Philipp Stanner <pstanner@...hat.com>

Reviewed-by: Takashi Iwai <tiwai@...e.de>

And feel free to take my ack to v2 if the further change will be only
about the description, too :)


thanks,

Takashi


> ---
>  sound/pci/korg1212/korg1212.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/pci/korg1212/korg1212.c b/sound/pci/korg1212/korg1212.c
> index 5c2cac201a28..b5428ac34d3b 100644
> --- a/sound/pci/korg1212/korg1212.c
> +++ b/sound/pci/korg1212/korg1212.c
> @@ -2106,7 +2106,7 @@ static int snd_korg1212_create(struct snd_card *card, struct pci_dev *pci)
>          for (i=0; i<kAudioChannels; i++)
>                  korg1212->volumePhase[i] = 0;
>  
> -	err = pcim_iomap_regions_request_all(pci, 1 << 0, "korg1212");
> +	err = pcim_request_all_regions(pci, "korg1212");
>  	if (err < 0)
>  		return err;
>  
> @@ -2128,7 +2128,9 @@ static int snd_korg1212_create(struct snd_card *card, struct pci_dev *pci)
>  		   korg1212->iomem2, iomem2_size,
>  		   stateName[korg1212->cardState]);
>  
> -	korg1212->iobase = pcim_iomap_table(pci)[0];
> +	korg1212->iobase = pcim_iomap(pci, 0, 0);
> +	if (!korg1212->iobase)
> +		return -ENOMEM;
>  
>  	err = devm_request_irq(&pci->dev, pci->irq, snd_korg1212_interrupt,
>                            IRQF_SHARED,
> -- 
> 2.45.2
>