linux-kernel - Re: [PATCH v2] ARM: Add support for STACKLEAK gcc plugin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZqzHNN27hwms0CB/@shell.armlinux.org.uk>
Date: Fri, 2 Aug 2024 12:47:00 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Jinjie Ruan <ruanjinjie@...wei.com>
Cc: ardb@...nel.org, arnd@...db.de, afd@...com, akpm@...ux-foundation.org,
	linus.walleij@...aro.org, eric.devolder@...cle.com, robh@...nel.org,
	kees@...nel.org, masahiroy@...nel.org, palmer@...osinc.com,
	samitolvanen@...gle.com, xiao.w.wang@...el.com,
	alexghiti@...osinc.com, nathan@...nel.org, jan.kiszka@...mens.com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-efi@...r.kernel.org
Subject: Re: [PATCH v2] ARM: Add support for STACKLEAK gcc plugin

On Mon, Jul 22, 2024 at 10:53:10AM +0800, Jinjie Ruan wrote:
> Gentle ping.
> 
> On 2024/6/24 10:36, Jinjie Ruan wrote:
> > Add the STACKLEAK gcc plugin to arm32 by adding the helper used by
> > stackleak common code: on_thread_stack(). It initialize the stack with the
> > poison value before returning from system calls which improves the kernel
> > security. Additionally, this disables the plugin in EFI stub code and
> > decompress code, which are out of scope for the protection.
> > 
> > Before the test on Qemu versatilepb board:
> > 	# echo STACKLEAK_ERASING  > /sys/kernel/debug/provoke-crash/DIRECT
> > 	lkdtm: Performing direct entry STACKLEAK_ERASING
> > 	lkdtm: XFAIL: stackleak is not supported on this arch (HAVE_ARCH_STACKLEAK=n)
> > 
> > After:
> > 	# echo STACKLEAK_ERASING  > /sys/kernel/debug/provoke-crash/DIRECT
> > 	lkdtm: Performing direct entry STACKLEAK_ERASING
> > 	lkdtm: stackleak stack usage:
> > 	  high offset: 80 bytes
> > 	  current:     280 bytes
> > 	  lowest:      696 bytes
> > 	  tracked:     696 bytes
> > 	  untracked:   192 bytes
> > 	  poisoned:    7220 bytes
> > 	  low offset:  4 bytes
> > 	lkdtm: OK: the rest of the thread stack is properly erased
> > 
> > Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
> > Acked-by: Ard Biesheuvel <ardb@...nel.org>

Is this a feature that you have a use case for?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!