linux-kernel - Re: [PATCH 3/4] Updating a deprecated use of strcpy in battry.c file.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gzgwAwoZXNCFRTpSbscd9V1DJSD9k6QKh3QaKNVmDWsQ@mail.gmail.com>
Date: Fri, 2 Aug 2024 16:19:14 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Muhammad Qasim Abdul Majeed <qasim.majeed20@...il.com>
Cc: rafael@...nel.org, lenb@...nel.org, linux-acpi@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] Updating a deprecated use of strcpy in battry.c file.

On Sat, Jul 6, 2024 at 10:11 AM Muhammad Qasim Abdul Majeed
<qasim.majeed20@...il.com> wrote:
>
> Replacing strcpy with strscpy.
> strcpy is a deprecated function.
> It should be removed from the kernel source.
>
> Link: https://github.com/KSPP/linux/issues/88
>
> Signed-off-by: Muhammad Qasim Abdul Majeed <qasim.majeed20@...il.com>
> ---
>  drivers/acpi/battery.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
> index b379401ff1c2..784f9234f1a4 100644
> --- a/drivers/acpi/battery.c
> +++ b/drivers/acpi/battery.c
> @@ -1193,8 +1193,8 @@ static int acpi_battery_add(struct acpi_device *device)
>         if (!battery)
>                 return -ENOMEM;
>         battery->device = device;
> -       strcpy(acpi_device_name(device), ACPI_BATTERY_DEVICE_NAME);
> -       strcpy(acpi_device_class(device), ACPI_BATTERY_CLASS);
> +       strscpy(acpi_device_name(device), ACPI_BATTERY_DEVICE_NAME);
> +       strscpy(acpi_device_class(device), ACPI_BATTERY_CLASS);
>         device->driver_data = battery;
>         mutex_init(&battery->lock);
>         mutex_init(&battery->sysfs_lock);
> --

Applied as 6.12 material with edited subject and changelog, thanks!