linux-kernel - Re: [PATCH v3] dt-bindings: edac: Add Altera SOCFPGA SDRAM EDAC binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABq9Dx4LDdHaknB6XgMvtT41tWtDx7YGnFCi6geSS-0J1UxrzQ@mail.gmail.com>
Date: Fri, 2 Aug 2024 16:32:37 +0200
From: Alessandro Zanni <alessandro.zanni87@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
	skhan@...uxfoundation.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] dt-bindings: edac: Add Altera SOCFPGA SDRAM EDAC binding

Thank you for the review.

This patch aims to be a conversion from txt file
"bindings/arm/altera/socfpga-sdram-edac.txt" to this
"bindings/edac/altr,sdram-edac.yaml" file.
That's why I also deleted the txt file in the patch.

Maybe I should have put a different title to make it clearer.

This is the original example in the txt file:
sdramedac {
    compatible = "altr,sdram-edac";
    altr,sdr-syscon = <&sdr>;
    interrupts = <0 39 4>;

and this is my conversion:
> +  - |
> +    memory-controller {
> +      compatible = "altr,sdram-edac";
> +      altr,sdr-syscon = <&sdr>;
> +      interrupts = <0 39 4>;

Sorry for that but, to me, it's not clear what I should convert in
this example to complete the yaml file.

Best regards,
Alessandro


Il giorno ven 2 ago 2024 alle ore 08:54 Krzysztof Kozlowski
<krzk@...nel.org> ha scritto:
>
> On 01/08/2024 18:10, Alessandro Zanni wrote:
> > Convert the device tree bindings for the Altera PCIe MSI controller
> >
> > Signed-off-by: Alessandro Zanni <alessandro.zanni87@...il.com>
> > ---
> >
>
> Subject: you did not add binding in this patch. Binding was already
> there. You converted one to DT schema.
>
>
> > Notes:
> >     v3: moved yaml file from arm/altera to the edac folder, removed items keys, added general node names
> >
>
> ...
>
> > +
> > +examples:
> > +  - |
> > +    memory-controller {
> > +      compatible = "altr,sdram-edac";
> > +      altr,sdr-syscon = <&sdr>;
> > +      interrupts = <0 39 4>;
>
> No improvements here.
>
> <form letter>
> This is a friendly reminder during the review process.
>
> It seems my or other reviewer's previous comments were not fully
> addressed. Maybe the feedback got lost between the quotes, maybe you
> just forgot to apply it. Please go back to the previous discussion and
> either implement all requested changes or keep discussing them.
>
> Thank you.
> </form letter>
>
>
> Best regards,
> Krzysztof
>