linux-kernel - Re: [PATCH v3] dt-bindings: edac: Add Altera SOCFPGA SDRAM EDAC binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20d128b3-ad81-4338-bd59-a039ddcbbadf@kernel.org>
Date: Fri, 2 Aug 2024 08:54:38 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Alessandro Zanni <alessandro.zanni87@...il.com>, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, skhan@...uxfoundation.org
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] dt-bindings: edac: Add Altera SOCFPGA SDRAM EDAC
 binding

On 01/08/2024 18:10, Alessandro Zanni wrote:
> Convert the device tree bindings for the Altera PCIe MSI controller
> 
> Signed-off-by: Alessandro Zanni <alessandro.zanni87@...il.com>
> ---
> 

Subject: you did not add binding in this patch. Binding was already
there. You converted one to DT schema.

> Notes:
>     v3: moved yaml file from arm/altera to the edac folder, removed items keys, added general node names
> 

...

> +
> +examples:
> +  - |
> +    memory-controller {
> +      compatible = "altr,sdram-edac";
> +      altr,sdr-syscon = <&sdr>;
> +      interrupts = <0 39 4>;

No improvements here.

<form letter>
This is a friendly reminder during the review process.

It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.

Thank you.
</form letter>

Best regards,
Krzysztof