linux-kernel - Re: [PATCH] char: xillybus: Don't destroy workqueue from work item running on it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024080311-legwarmer-ricotta-d4fd@gregkh>
Date: Sat, 3 Aug 2024 08:56:28 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Eli Billauer <eli.billauer@...il.com>
Cc: arnd@...db.de, linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH] char: xillybus: Don't destroy workqueue from work item
 running on it

On Thu, Aug 01, 2024 at 03:11:26PM +0300, Eli Billauer wrote:
> Triggered by a kref decrement, destroy_workqueue() may be called from
> within a work item for destroying its own workqueue. This illegal
> situation is averted by adding a module-global workqueue for exclusive
> use of the offending work item. Other work items continue to be queued
> on per-device workqueues to ensure performance.
> 
> Reported-by: syzbot+91dbdfecdd3287734d8e@...kaller.appspotmail.com
> Closes: https://lore.kernel.org/lkml/0000000000000ab25a061e1dfe9f@google.com/
> Signed-off-by: Eli Billauer <eli.billauer@...il.com>
> ---
>  drivers/char/xillybus/xillyusb.c | 16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)

What commit id does this fix?  Should it also go to stable kernels?

thanks,

greg k-h