linux-kernel - Re: [PATCH 4/5] Compiler Attributes: fix formatting of GCC/Clang doc links

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240804180338.GD2627063@thelio-3990X>
Date: Sun, 4 Aug 2024 11:03:38 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: Miguel Ojeda <ojeda@...nel.org>
Cc: Nick Desaulniers <ndesaulniers@...gle.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>, llvm@...ts.linux.dev,
	linux-kernel@...r.kernel.org, patches@...ts.linux.dev
Subject: Re: [PATCH 4/5] Compiler Attributes: fix formatting of GCC/Clang doc
 links

On Sat, Aug 03, 2024 at 07:19:32PM +0200, Miguel Ojeda wrote:
> Over time, some links have been added that did not follow the formatting
> of the rest. Fix it for consistency.
> 
> No non-whitespace changes intended.
> 
> Signed-off-by: Miguel Ojeda <ojeda@...nel.org>

Reviewed-by: Nathan Chancellor <nathan@...nel.org>

It might be worth calling out the expected format (aligned on the colon)
since I was initially confused until I looked a little harder :)

> ---
>  include/linux/compiler_attributes.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/include/linux/compiler_attributes.h b/include/linux/compiler_attributes.h
> index 2d1ad2a74a4e..a6e8c9406f7a 100644
> --- a/include/linux/compiler_attributes.h
> +++ b/include/linux/compiler_attributes.h
> @@ -226,7 +226,7 @@
>   *   goto <label>;
>   *   return [expression];
>   *
> - *  gcc: https://gcc.gnu.org/onlinedocs/gcc/Statement-Attributes.html#Statement-Attributes
> + *   gcc: https://gcc.gnu.org/onlinedocs/gcc/Statement-Attributes.html#Statement-Attributes
>   * clang: https://clang.llvm.org/docs/AttributeReference.html#fallthrough
>   */
>  #if __has_attribute(__fallthrough__)
> @@ -236,7 +236,7 @@
>  #endif
>  
>  /*
> - * gcc: https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#Common-Function-Attributes
> + *   gcc: https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#Common-Function-Attributes
>   * clang: https://clang.llvm.org/docs/AttributeReference.html#flatten
>   */
>  # define __flatten			__attribute__((flatten))
> @@ -264,8 +264,8 @@
>  /*
>   * Optional: only supported since GCC >= 7.1
>   *
> - *      gcc: https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-no_005fprofile_005finstrument_005ffunction-function-attribute
> - *    clang: https://clang.llvm.org/docs/AttributeReference.html#no-profile-instrument-function
> + *   gcc: https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-no_005fprofile_005finstrument_005ffunction-function-attribute
> + * clang: https://clang.llvm.org/docs/AttributeReference.html#no-profile-instrument-function
>   */
>  #if __has_attribute(__no_profile_instrument_function__)
>  # define __no_profile                  __attribute__((__no_profile_instrument_function__))
> @@ -283,7 +283,7 @@
>   * Optional: only supported since GCC >= 11.1
>   *
>   *   gcc: https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-no_005fstack_005fprotector-function-attribute
> - *   clang: https://clang.llvm.org/docs/AttributeReference.html#no-stack-protector-safebuffers
> + * clang: https://clang.llvm.org/docs/AttributeReference.html#no-stack-protector-safebuffers
>   */
>  #if __has_attribute(__no_stack_protector__)
>  # define __no_stack_protector		__attribute__((__no_stack_protector__))
> -- 
> 2.46.0
>