linux-kernel - Re: [PATCH 5/5] Compiler Attributes: make version constraints more consistent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240804180447.GE2627063@thelio-3990X>
Date: Sun, 4 Aug 2024 11:04:47 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: Miguel Ojeda <ojeda@...nel.org>
Cc: Nick Desaulniers <ndesaulniers@...gle.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>, llvm@...ts.linux.dev,
	linux-kernel@...r.kernel.org, patches@...ts.linux.dev
Subject: Re: [PATCH 5/5] Compiler Attributes: make version constraints more
 consistent

On Sat, Aug 03, 2024 at 07:19:33PM +0200, Miguel Ojeda wrote:
> Over time, some version constraints have been added that did not follow
> the formatting of the rest. Fix it for consistency.
> 
> Some of the version requirements can be simplified, too.
> 
> Signed-off-by: Miguel Ojeda <ojeda@...nel.org>

Yeah, I think just having the major version is reasonable, especially
since Clang has moved to GCC's version scheme of x.0 for main, x.1 for
release.

Reviewed-by: Nathan Chancellor <nathan@...nel.org>

> ---
>  include/linux/compiler_attributes.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/include/linux/compiler_attributes.h b/include/linux/compiler_attributes.h
> index a6e8c9406f7a..908e59e261c0 100644
> --- a/include/linux/compiler_attributes.h
> +++ b/include/linux/compiler_attributes.h
> @@ -112,7 +112,7 @@
>  
>  /*
>   * Optional: not supported by gcc
> - * Optional: only supported since clang >= 14.0
> + * Optional: only supported since clang >= 14
>   *
>   * clang: https://clang.llvm.org/docs/AttributeReference.html#diagnose_as_builtin
>   */
> @@ -146,7 +146,7 @@
>  #endif
>  
>  /*
> - * Optional: only supported since clang >= 14.0
> + * Optional: only supported since clang >= 14
>   *
>   *   gcc: https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-error-function-attribute
>   * clang: https://clang.llvm.org/docs/AttributeReference.html#error-warning
> @@ -262,7 +262,7 @@
>  #endif
>  
>  /*
> - * Optional: only supported since GCC >= 7.1
> + * Optional: only supported since gcc >= 7
>   *
>   *   gcc: https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-no_005fprofile_005finstrument_005ffunction-function-attribute
>   * clang: https://clang.llvm.org/docs/AttributeReference.html#no-profile-instrument-function
> @@ -280,7 +280,7 @@
>  #define __noreturn                      __attribute__((__noreturn__))
>  
>  /*
> - * Optional: only supported since GCC >= 11.1
> + * Optional: only supported since gcc >= 11
>   *
>   *   gcc: https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-no_005fstack_005fprotector-function-attribute
>   * clang: https://clang.llvm.org/docs/AttributeReference.html#no-stack-protector-safebuffers
> @@ -388,7 +388,7 @@
>  #define __must_check                    __attribute__((__warn_unused_result__))
>  
>  /*
> - * Optional: only supported since clang >= 14.0
> + * Optional: only supported since clang >= 14
>   *
>   *   gcc: https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-warning-function-attribute
>   * clang: https://clang.llvm.org/docs/AttributeReference.html#error-warning
> @@ -400,7 +400,7 @@
>  #endif
>  
>  /*
> - * Optional: only supported since clang >= 14.0
> + * Optional: only supported since clang >= 14
>   *
>   * clang: https://clang.llvm.org/docs/AttributeReference.html#disable-sanitizer-instrumentation
>   *
> -- 
> 2.46.0
>