linux-kernel - Re: [PATCH v9 15/17] drm/vkms: Create KUnit tests for YUV conversions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <61b3248a-a132-432b-afc2-f7415b0e2db5@quicinc.com>
Date: Mon, 5 Aug 2024 10:09:48 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Louis Chauvet <louis.chauvet@...tlin.com>,
        Rodrigo Siqueira
	<rodrigosiqueiramelo@...il.com>,
        Melissa Wen <melissa.srw@...il.com>,
        Maíra Canal <mairacanal@...eup.net>,
        Haneen Mohammed
	<hamohammed.sa@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...il.com>, Jonathan Corbet <corbet@....net>,
        <rdunlap@...radead.org>, <arthurgrillo@...eup.net>,
        <pekka.paalanen@...oniitty.fi>
CC: <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
        <linux-doc@...r.kernel.org>, <jeremie.dautheribes@...tlin.com>,
        <miquel.raynal@...tlin.com>, <thomas.petazzoni@...tlin.com>,
        <seanpaul@...gle.com>, <marcheu@...gle.com>,
        <nicolejadeyee@...gle.com>,
        Pekka Paalanen <pekka.paalanen@...labora.com>
Subject: Re: [PATCH v9 15/17] drm/vkms: Create KUnit tests for YUV conversions

On 8/2/24 09:10, Louis Chauvet wrote:
> From: Arthur Grillo <arthurgrillo@...eup.net>
> 
> Create KUnit tests to test the conversion between YUV and RGB. Test each
> conversion and range combination with some common colors.
> 
> The code used to compute the expected result can be found in comment.
> 
> [Louis Chauvet:
> - fix minor formating issues (whitespace, double line)
> - change expected alpha from 0x0000 to 0xffff
> - adapt to the new get_conversion_matrix usage
> - apply the changes from Arthur
> - move struct pixel_yuv_u8 to the test itself]
> 
> Signed-off-by: Arthur Grillo <arthurgrillo@...eup.net>
> Acked-by: Pekka Paalanen <pekka.paalanen@...labora.com>
> Signed-off-by: Louis Chauvet <louis.chauvet@...tlin.com>
> ---
>   drivers/gpu/drm/vkms/Kconfig                  |  15 ++
>   drivers/gpu/drm/vkms/Makefile                 |   1 +
>   drivers/gpu/drm/vkms/tests/.kunitconfig       |   4 +
>   drivers/gpu/drm/vkms/tests/Makefile           |   3 +
>   drivers/gpu/drm/vkms/tests/vkms_format_test.c | 230 ++++++++++++++++++++++++++
>   drivers/gpu/drm/vkms/vkms_formats.c           |   7 +-
>   drivers/gpu/drm/vkms/vkms_formats.h           |   5 +
>   7 files changed, 263 insertions(+), 2 deletions(-)
...
> diff --git a/drivers/gpu/drm/vkms/tests/vkms_format_test.c b/drivers/gpu/drm/vkms/tests/vkms_format_test.c
> new file mode 100644
> index 000000000000..c7c556b4fd98
> --- /dev/null
> +++ b/drivers/gpu/drm/vkms/tests/vkms_format_test.c
> @@ -0,0 +1,230 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +
...
> +kunit_test_suite(vkms_format_test_suite);
> +
> +MODULE_LICENSE("GPL");

Please add a MODULE_DESCRIPTION()

Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
description is missing"), a module without a MODULE_DESCRIPTION() will
result in a warning when built with make W=1. Recently, multiple 
developers have been eradicating these warnings treewide, so please 
don't introduce a new one.

/jeff