[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <max7qd6eafatuse22ymmbfhumrctvf2lenwzhn6sxsm5ugebh6@udblqrtlblbf>
Date: Mon, 5 Aug 2024 20:11:10 +0300
From: Serge Semin <fancer.lancer@...il.com>
To: Furong Xu <0x1207@...il.com>, Vladimir Oltean <olteanv@...il.com>
Cc: Andrew Lunn <andrew@...n.ch>, "David S. Miller" <davem@...emloft.net>,
Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose Abreu <joabreu@...opsys.com>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>,
Joao Pinto <jpinto@...opsys.com>, netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, xfr@...look.com, rock.xu@....com
Subject: Re: [PATCH net-next v1 0/5] net: stmmac: FPE via ethtool + tc
Hi Furong
On Wed, Jul 31, 2024 at 06:43:11PM +0800, Furong Xu wrote:
> Move the Frame Preemption(FPE) over to the new standard API which uses
> ethtool-mm/tc-mqprio/tc-taprio.
Thank you very much for the series. I am not that much aware of the
FPE and ethtool MAC Merge guts. But I had a thoughtful glance to the
FPE-handshaking algo and got to a realization that all the FPE-related
data defined in the include/linux/stmmac.h weren't actually
platform-data. All of that are the run-time settings utilized during
the handshaking algo execution.
So could you please move the fpe_cfg field to the stmmac_priv data and
move the FPE-related declarations from the include/linux/stmmac.h
header file to the drivers/net/ethernet/stmicro/stmmac/stmmac.h file?
It's better to be done in a pre-requisite (preparation) patch of your
series.
Another useful cleanup would be moving the entire FPE-implementation
from stmmac_main.c to a separate module. Thus the main
driver code would be simplified a bit. I guess it could be moved to
the stmmac_tc.c file since FPE is the TC-related feature. Right?
Vladimir, what do you think about the suggestions above?
-Serge(y)
>
> Furong Xu (5):
> net: stmmac: configure FPE via ethtool-mm
> net: stmmac: support fp parameter of tc-mqprio
> net: stmmac: support fp parameter of tc-taprio
> net: stmmac: drop unneeded FPE handshake code
> net: stmmac: silence FPE kernel logs
>
> .../net/ethernet/stmicro/stmmac/dwmac4_core.c | 6 +
> drivers/net/ethernet/stmicro/stmmac/dwmac5.c | 37 +++++-
> drivers/net/ethernet/stmicro/stmmac/dwmac5.h | 7 ++
> drivers/net/ethernet/stmicro/stmmac/hwif.h | 14 +++
> drivers/net/ethernet/stmicro/stmmac/stmmac.h | 3 +
> .../ethernet/stmicro/stmmac/stmmac_ethtool.c | 111 ++++++++++++++++++
> .../net/ethernet/stmicro/stmmac/stmmac_main.c | 25 ++--
> .../net/ethernet/stmicro/stmmac/stmmac_tc.c | 95 ++++++++++-----
> include/linux/stmmac.h | 2 +-
> 9 files changed, 248 insertions(+), 52 deletions(-)
>
> --
> 2.34.1
>
>
Powered by blists - more mailing lists