linux-kernel - Re: [PATCH] bus: ti-sysc: Use of_property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <172287945269.306491.8860968743342697729.b4-ty@baylibre.com>
Date: Mon, 05 Aug 2024 10:37:32 -0700
From: Kevin Hilman <khilman@...libre.com>
To: Aaro Koskinen <aaro.koskinen@....fi>, 
 Andreas Kemnade <andreas@...nade.info>, Roger Quadros <rogerq@...nel.org>, 
 Tony Lindgren <tony@...mide.com>, "Rob Herring (Arm)" <robh@...nel.org>
Cc: linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bus: ti-sysc: Use of_property_present()


On Wed, 31 Jul 2024 13:12:39 -0600, Rob Herring (Arm) wrote:
> Use of_property_present() to test for property presence rather than
> of_get_property(). This is part of a larger effort to remove callers
> of of_get_property() and similar functions. of_get_property() leaks
> the DT property data pointer which is a problem for dynamically
> allocated nodes which may be freed.
> 
> The code was also incorrectly assigning the return value to a 'struct
> property' pointer. It didn't matter as "prop" was never dereferenced.
> 
> [...]

Applied, thanks!

[1/1] bus: ti-sysc: Use of_property_present()
      commit: 0070dc29c85f0859a6071844b88fca6bce2974e4

Best regards,
-- 
Kevin Hilman <khilman@...libre.com>