linux-kernel - Re: [PATCH] bus: ti-sysc: Use of_property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cb3d6f0b-4513-4744-8c16-c3f76ee36fef@kernel.org>
Date: Tue, 6 Aug 2024 08:40:56 +0300
From: Roger Quadros <rogerq@...nel.org>
To: Kevin Hilman <khilman@...libre.com>, "Rob Herring (Arm)"
 <robh@...nel.org>, Aaro Koskinen <aaro.koskinen@....fi>,
 Andreas Kemnade <andreas@...nade.info>, Tony Lindgren <tony@...mide.com>
Cc: linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bus: ti-sysc: Use of_property_present()

Hi Kevin,

On 05/08/2024 20:36, Kevin Hilman wrote:
> Hi Roger,
> 
> Roger Quadros <rogerq@...nel.org> writes:
> 
>> On 31/07/2024 22:12, Rob Herring (Arm) wrote:
>>> Use of_property_present() to test for property presence rather than
>>> of_get_property(). This is part of a larger effort to remove callers
>>> of of_get_property() and similar functions. of_get_property() leaks
>>> the DT property data pointer which is a problem for dynamically
>>> allocated nodes which may be freed.
>>>
>>> The code was also incorrectly assigning the return value to a 'struct
>>> property' pointer. It didn't matter as "prop" was never dereferenced.
>>>
>>> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
>>
>> Reviewed by: Roger Quadros <rogerq@...nel.org>
> 
> just FYI, missing a '-' in your Reviewed-by, which means tools like b4
> will not spot it.  I added it manually this time cuz I happened to
> notice it was missing.

Sorry, my bad. Thanks for fixing this up.

-- 
cheers,
-roger