linux-kernel - Re: [PATCH] ALSA: hda: Manally set pins to correct HP firmware settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875xsfl7yb.wl-tiwai@suse.de>
Date: Mon, 05 Aug 2024 09:55:40 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Steven 'Steve' Kendall <skend@...omium.org>
Cc: Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: hda: Manally set pins to correct HP firmware settings

On Sat, 03 Aug 2024 01:50:11 +0200,
Steven 'Steve' Kendall wrote:
> 
> In recent HP UEFI firmware (likely v2.15 and above, tested on 2.27),
> these pins are incorrectly set for HDMI/DP audio. Tested on
> HP MP9 G4 Retail System AMS. Pins for the ports set to escalating values
> (0x70, 80, 90) to have differing default associations, though in my
> testing setting all pins to 0x70 also worked as suggested by the first
> link below. Tested audio with two monitors connected via DisplayPort.
> 
> Link: https://forum.manjaro.org/t/intel-cannon-lake-pch-cavs-conexant-cx20632-no-sound-at-hdmi-or-displayport/133494
> Link: https://bbs.archlinux.org/viewtopic.php?id=270523
> Signed-off-by: Steven 'Steve' Kendall <skend@...omium.org>

I suppose it can be rather added to force_connect_list[] table like a
few other HP models, instead?  Something like below.

Or, maybe we can apply with vendor HP (103c) in the case of Kaybelake.
I got another report indicating a same issue, but with the ID
103c:83e2.


thanks,

Takashi

-- 8< --
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -1989,6 +1989,7 @@ static int hdmi_add_cvt(struct hda_codec *codec, hda_nid_t cvt_nid)
 }
 
 static const struct snd_pci_quirk force_connect_list[] = {
+	SND_PCI_QUIRK(0x103c, 0x83ef, "HP MP9 G4 Retail System AMS", 1),
 	SND_PCI_QUIRK(0x103c, 0x870f, "HP", 1),
 	SND_PCI_QUIRK(0x103c, 0x871a, "HP", 1),
 	SND_PCI_QUIRK(0x103c, 0x8711, "HP", 1),