linux-kernel - Re: [PATCH] ALSA: hda: Manally set pins to correct HP firmware settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <83d0a673-007e-4e0e-8db3-856ae02cd67c@linux.intel.com>
Date: Mon, 5 Aug 2024 10:43:15 +0200
From: Amadeusz Sławiński
 <amadeuszx.slawinski@...ux.intel.com>
To: Steven 'Steve' Kendall <skend@...omium.org>,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Cc: linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: hda: Manally set pins to correct HP firmware
 settings

On 8/3/2024 1:50 AM, Steven 'Steve' Kendall wrote:
> In recent HP UEFI firmware (likely v2.15 and above, tested on 2.27),
> these pins are incorrectly set for HDMI/DP audio. Tested on
> HP MP9 G4 Retail System AMS. Pins for the ports set to escalating values
> (0x70, 80, 90) to have differing default associations, though in my
> testing setting all pins to 0x70 also worked as suggested by the first
> link below. Tested audio with two monitors connected via DisplayPort.
> 
> Link: https://forum.manjaro.org/t/intel-cannon-lake-pch-cavs-conexant-cx20632-no-sound-at-hdmi-or-displayport/133494
> Link: https://bbs.archlinux.org/viewtopic.php?id=270523
> Signed-off-by: Steven 'Steve' Kendall <skend@...omium.org>
> ---
>   sound/pci/hda/patch_hdmi.c | 21 ++++++++++++++++++++-
>   1 file changed, 20 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
> index 707d203ba652..dfcbd41097f8 100644
> --- a/sound/pci/hda/patch_hdmi.c
> +++ b/sound/pci/hda/patch_hdmi.c
> @@ -3115,6 +3115,25 @@ static int patch_i915_hsw_hdmi(struct hda_codec *codec)
>   				     enable_silent_stream);
>   }
>   
> +static const struct snd_pci_quirk kaby_hdmi_list[] = {

I see that Takashi gave some other suggestion, but in case there is 
decision to proceed with this patch, change kaby_hdmi_list to kbl_hdmi_list.

> +	SND_PCI_QUIRK(0x103c, 0x83ef, "HP MP9 G4 Retail System AMS", 1),
> +	{}
> +};
> +
> +static int patch_i915_kaby_hdmi(struct hda_codec *codec)

and same here, kaby -> kbl

or maybe even consider cnl, as both linked issues seem to be reported on 
devices with Cannon Lake audio controller?