linux-kernel - Re: [PATCH v3 3/5] btrfs: set rst_search_commit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240805162843.GZ17473@twin.jikos.cz>
Date: Mon, 5 Aug 2024 18:28:43 +0200
From: David Sterba <dsterba@...e.cz>
To: Johannes Thumshirn <jth@...nel.org>
Cc: Chris Mason <clm@...com>, Josef Bacik <josef@...icpanda.com>,
	David Sterba <dsterba@...e.com>, linux-btrfs@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Johannes Thumshirn <johannes.thumshirn@....com>,
	Qu Wenruo <wqu@...e.com>
Subject: Re: [PATCH v3 3/5] btrfs: set rst_search_commit_root in case of
 relocation

On Wed, Jul 31, 2024 at 10:43:05PM +0200, Johannes Thumshirn wrote:
> From: Johannes Thumshirn <johannes.thumshirn@....com>
> 
> Set rst_search_commit_root in the btrfs_io_stripe we're passing to
> btrfs_map_block() in case we're doing data relocation.
> 
> Reviewed-by: Josef Bacik <josef@...icpanda.com>
> Reviewed-by: Qu Wenruo <wqu@...e.com>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@....com>
> ---
>  fs/btrfs/bio.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/bio.c b/fs/btrfs/bio.c
> index dfb32f7d3fc2..c6563616c813 100644
> --- a/fs/btrfs/bio.c
> +++ b/fs/btrfs/bio.c
> @@ -679,7 +679,8 @@ static bool btrfs_submit_chunk(struct btrfs_bio *bbio, int mirror_num)
>  	blk_status_t ret;
>  	int error;
>  
> -	smap.rst_search_commit_root = !bbio->inode;
> +	smap.rst_search_commit_root =
> +		(!bbio->inode || btrfs_is_data_reloc_root(inode->root));

Please use an 'if' here