linux-kernel - Re: [PATCH v2 0/4] Cleanup Spreadtum/Unisoc ARM64 DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZrD9+oJW1icQlphq@standask-GA-A55M-S2HP>
Date: Mon, 5 Aug 2024 18:29:46 +0200
From: Stanislav Jakubek <stano.jakubek@...il.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Baolin Wang <baolin.wang7@...il.com>, Orson Zhai <orsonzhai@...il.com>,
	devicetree@...r.kernel.org,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	linux-kernel@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>,
	linux-arm-kernel@...ts.infradead.org,
	Baolin Wang <baolin.wang@...ux.alibaba.com>,
	Chunyan Zhang <zhang.lyra@...il.com>
Subject: Re: [PATCH v2 0/4] Cleanup Spreadtum/Unisoc ARM64 DT

Hi all,

On Mon, Aug 05, 2024 at 09:00:20AM -0600, Rob Herring (Arm) wrote:
> 
[snip]
> 
> New warnings running 'make CHECK_DTBS=y sprd/sc9836-openphone.dtb sprd/sp9860g-1h10.dtb' for cover.1722842066.git.stano.jakubek@...il.com:
> 
> arch/arm64/boot/dts/sprd/sp9860g-1h10.dtb: fuel-gauge@a00: 'battery-detect-gpios' is a required property
> 	from schema $id: http://devicetree.org/schemas/power/supply/sc27xx-fg.yaml#

This is a straigtforward fix, the sc2731.dtsi has ...-gpio instead of ...-gpios
I can fix this in another patch, I'd like to get this series merged first.

> arch/arm64/boot/dts/sprd/sp9860g-1h10.dtb: fuel-gauge@a00: 'sprd,calib-resistance-micro-ohms' is a required property
> 	from schema $id: http://devicetree.org/schemas/power/supply/sc27xx-fg.yaml#

SPRD folks will have to chime in here as I do not have the board or any
other source of information about it, so I cannot add this property.

> arch/arm64/boot/dts/sprd/sp9860g-1h10.dtb: fuel-gauge@a00: 'bat-detect-gpio', 'interrupt-parent', 'interrupts' do not match any of the regexes: 'pinctrl-[0-9]+'
> 	from schema $id: http://devicetree.org/schemas/power/supply/sc27xx-fg.yaml#

Looking at the driver, it seems to me that the interrupts are required, and
thus should be added to the bindings. I can send a patch.

Looking at the sc2731-fgu dtsi again, it seems like there's some further
fixes/improvements that could be made (disable by default, move the
monitored-battery to board DTS, etc.).

Either way, this series should be good to go.

Thanks,
Stanislav