[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240805164543.GL2636630@kernel.org>
Date: Mon, 5 Aug 2024 17:45:43 +0100
From: Simon Horman <horms@...nel.org>
To: Uros Bizjak <ubizjak@...il.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH v2] net/chelsio/libcxgb: Add __percpu annotations to
libcxgb_ppm.c
On Sun, Aug 04, 2024 at 05:46:09PM +0200, Uros Bizjak wrote:
> Compiling libcxgb_ppm.c results in several sparse warnings:
>
> libcxgb_ppm.c:368:15: warning: incorrect type in assignment (different address spaces)
> libcxgb_ppm.c:368:15: expected struct cxgbi_ppm_pool *pools
> libcxgb_ppm.c:368:15: got void [noderef] __percpu *_res
> libcxgb_ppm.c:374:48: warning: incorrect type in initializer (different address spaces)
> libcxgb_ppm.c:374:48: expected void const [noderef] __percpu *__vpp_verify
> libcxgb_ppm.c:374:48: got struct cxgbi_ppm_pool *
> libcxgb_ppm.c:484:19: warning: incorrect type in assignment (different address spaces)
> libcxgb_ppm.c:484:19: expected struct cxgbi_ppm_pool [noderef] __percpu *pool
> libcxgb_ppm.c:484:19: got struct cxgbi_ppm_pool *[assigned] pool
> libcxgb_ppm.c:511:21: warning: incorrect type in argument 1 (different address spaces)
> libcxgb_ppm.c:511:21: expected void [noderef] __percpu *__pdata
> libcxgb_ppm.c:511:21: got struct cxgbi_ppm_pool *[assigned] pool
>
> Add __percpu annotation to *pools and *pool percpu pointers and to
> ppm_alloc_cpu_pool() function that returns percpu pointer to fix
> these warnings.
>
> Compile tested only, but there is no difference in the resulting object file.
>
> Signed-off-by: Uros Bizjak <ubizjak@...il.com>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Paolo Abeni <pabeni@...hat.com>
> ---
> v2: Limit source to less than 80 columns wide.
Thanks for the update.
Reviewed-by: Simon Horman <horms@...nel.org>
Powered by blists - more mailing lists