linux-kernel - Re: [PATCH v8 2/3] firmware: ti_sci: Add support for querying the firmware caps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240806154201.tfqq27csd6zvtbrw@browsing>
Date: Tue, 6 Aug 2024 10:42:01 -0500
From: Nishanth Menon <nm@...com>
To: Markus Schneider-Pargmann <msp@...libre.com>
CC: Tero Kristo <kristo@...nel.org>, Santosh Shilimkar <ssantosh@...nel.org>,
        Vibhore Vardhan <vibhore@...com>, Kevin Hilman <khilman@...libre.com>,
        "Dhruva Gole" <d-gole@...com>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, Georgi Vlaev <g-vlaev@...com>
Subject: Re: [PATCH v8 2/3] firmware: ti_sci: Add support for querying the
 firmware caps

On 21:54-20240801, Markus Schneider-Pargmann wrote:
[...]

>  static int ti_sci_cmd_core_reboot(const struct ti_sci_handle *handle)
>  {
>  	struct ti_sci_info *info;
> @@ -3113,6 +3172,12 @@ static void ti_sci_setup_ops(struct ti_sci_info *info)
>  
>  	pmops->lpm_wake_reason = ti_sci_msg_cmd_lpm_wake_reason;
>  
> +	if (info->fw_caps & MSG_FLAG_CAPS_LPM_DM_MANAGED) {
> +		pr_debug("detected DM managed LPM in fw_caps\n");
> +		ops->pm_ops.set_device_constraint = ti_sci_cmd_set_device_constraint;
> +		ops->pm_ops.set_latency_constraint = ti_sci_cmd_set_latency_constraint;
pmops-> ?

Also lpm_wake_reason makes sense only if the flag is set, so
this should probably be the first patch in your series?

> +	}

Side-note: please drop bouncing emails from your patch CC list.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D