linux-kernel - Re: [PATCH v8 1/3] firmware: ti_sci: Introduce Power Management Ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6zk5auljbsjnimtrftr6se2jrhcibidc2oq2qpdc7yncauvui7@peyzkaszsm2c>
Date: Tue, 6 Aug 2024 20:47:09 +0200
From: Markus Schneider-Pargmann <msp@...libre.com>
To: Nishanth Menon <nm@...com>
Cc: Tero Kristo <kristo@...nel.org>, 
	Santosh Shilimkar <ssantosh@...nel.org>, Vibhore Vardhan <vibhore@...com>, 
	Kevin Hilman <khilman@...libre.com>, Dhruva Gole <d-gole@...com>, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, Dave Gerlach <d-gerlach@...com>, 
	Georgi Vlaev <g-vlaev@...com>, Akashdeep Kaur <a-kaur@...com>
Subject: Re: [PATCH v8 1/3] firmware: ti_sci: Introduce Power Management Ops

Hi Nishanth,

On Tue, Aug 06, 2024 at 10:39:12AM GMT, Nishanth Menon wrote:
> On 21:54-20240801, Markus Schneider-Pargmann wrote:
> > From: Dave Gerlach <d-gerlach@...com>
> [...]
> 
> > +	pmops->lpm_wake_reason = ti_sci_msg_cmd_lpm_wake_reason;
> 
> did you miss populating the rest of the pm ops?
> 	See https://lore.kernel.org/all/202408031302.28NpPykP-lkp@intel.com/

No, I didn't miss populating the pmops.

set_latency_constraint() and set_device_constraint() are only added to
pmops once the firmware capabilities are added in the next patch.
set_io_isolation() and prepare_sleep() are not added to pmops as the
usage outside of ti_sci.c is not planned. These are only used for
suspend/resume in the third patch.

I will rearrange the patches and integrate the functions required for
suspend/resume with the suspend/resume patch to avoid any build
warnings.

Best
Markus

> It might be better to introduce the APIs one at a time?
> 
> -- 
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D