linux-kernel - Re: [PATCH 2/2] dt-bindings: iio: asahi-kasei,ak8975: drop incorrect AK09116 compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240806171113.0cf9b992@jic23-huawei>
Date: Tue, 6 Aug 2024 17:11:13 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Conor Dooley <conor@...nel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Lars-Peter Clausen
 <lars@...afoo.de>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Jonathan Albrieux
 <jonathan.albrieux@...il.com>, Matt Ranostay <matt@...ostay.sg>,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: iio: asahi-kasei,ak8975: drop
 incorrect AK09116 compatible

On Tue, 6 Aug 2024 17:02:49 +0100
Conor Dooley <conor@...nel.org> wrote:

> On Tue, Aug 06, 2024 at 07:30:16AM +0200, Krzysztof Kozlowski wrote:
> > All compatibles in this binding without prefixes were deprecated, so
> > adding a new deprecated one after some time is not allowed, because it
> > defies the core logic of deprecating things.
> > 
> > Drop the AK09916 vendorless compatible.
> > 
> > Fixes: 76e28aa97fa0 ("iio: magnetometer: ak8975: add AK09116 support")
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> > 
> > ---
> > 
> > Offending commit did not even bother to Cc devicetree mailing list and
> > DT maintainers... Lovely. Let's ignore submitting patches and
> > maintainers just to sneak my important patch into the kernel.
> 
> :/
> 
> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

Let's assume mistake rather than malicious.
I should have noticed this :(

Anyhow, applied both patches to the togreg branch of iio.git.
Initially pushed out as testing for 0-day to take a look at other
stuff that's queued up.

Jonathan

> 
> Thanks,
> Conor.
> 
> > ---
> >  .../devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml b/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml
> > index 9790f75fc669..fe5145d3b73c 100644
> > --- a/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml
> > +++ b/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml
> > @@ -23,7 +23,6 @@ properties:
> >            - ak8963
> >            - ak09911
> >            - ak09912
> > -          - ak09916
> >          deprecated: true
> >  
> >    reg:
> > -- 
> > 2.43.0
> >