linux-kernel - Re: [PATCH V2 00/10] AMD XDNA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <23f5f0ea-305c-15c0-4578-ef1307621d07@amd.com>
Date: Tue, 6 Aug 2024 10:18:31 -0700
From: Lizhi Hou <lizhi.hou@....com>
To: Markus Elfring <Markus.Elfring@....de>, <dri-devel@...ts.freedesktop.org>,
	Oded Gabbay <ogabbay@...nel.org>
CC: LKML <linux-kernel@...r.kernel.org>, George Yang <George.Yang@....com>,
	<king.tam@....com>, Max Zhen <max.zhen@....com>, Min Ma <min.ma@....com>,
	Narendra Gutta <VenkataNarendraKumar.Gutta@....com>, Sonal Santan
	<sonal.santan@....com>
Subject: Re: [PATCH V2 00/10] AMD XDNA driver


On 8/6/24 01:05, Markus Elfring wrote:
> …
>> Changes since v1:
>> - Remove some inline defines
>> - Minor changes based code review comments
> …
>
> How “good” does such a version description fit to previous
> patch review feedback (like the following)?
>
> https://lkml.org/lkml/2024/7/19/803
> https://lore.kernel.org/linux-kernel/010a46ba-9dc4-e3e3-7894-b28b312c6ab1@amd.com/
> [01/10] accel/amdxdna: Add a new driver for AMD AI Engine
> “guard looks cleaner. We will use it.”
We reconsidered this request and searched accel and drm subsystem. I did 
not see it was used. This does not look like a required change for 
upstream at this moment. We would keep the current code for this patch 
series.
>
>
> Can further adjustment suggestions be taken better into account?

I went through all your comments. I made the required changes which are 
defined in coding style document. And thanks for pointing those out. 
Please understand we would only make required change at this moment. For 
the nice to have changes, we may consider to change in the future patches.


Thanks,

Lizhi

>
> Regards,
> Markus