linux-kernel - Re: [PATCH v3 4/4] selftests: ALSA: Cover userspace-driven timers with test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <038cb9ff-4028-4179-9722-df324e29c73d@sirena.org.uk>
Date: Tue, 6 Aug 2024 14:04:16 +0100
From: Mark Brown <broonie@...nel.org>
To: Ivan Orlov <ivan.orlov0322@...il.com>
Cc: perex@...ex.cz, tiwai@...e.com, corbet@....net, shuah@...nel.org,
	linux-kselftest@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
	christophe.jaillet@...adoo.fr, aholzinger@....de
Subject: Re: [PATCH v3 4/4] selftests: ALSA: Cover userspace-driven timers
 with test

On Tue, Aug 06, 2024 at 01:52:43PM +0100, Ivan Orlov wrote:

> -TEST_GEN_PROGS := mixer-test pcm-test test-pcmtest-driver
> +TEST_GEN_PROGS := mixer-test pcm-test utimer-test test-pcmtest-driver global-timer

This is adding the timer timer tests as standard kselftests to be run by
the wrapper script...

> index 000000000000..c15ec0ba851a
> --- /dev/null
> +++ b/tools/testing/selftests/alsa/global-timer.c

> +int main(int argc, char *argv[])
> +{
> +	int device, subdevice, timeout;
> +
> +	if (argc < 4) {
> +		perror("Usage: %s <device> <subdevice> <timeout>");
> +		return EXIT_FAILURE;
> +	}

...but this requires specific arguments to be run which the kselftest
runner won't supply.  I'd expect it to be a good default to enumerate
and test every possible device and generate a test for each.  However it
looks like this is really intended not as a standalone test but rather
as something run from within utimer-test, in that case it should be a
TEST_GEN_PROGS_EXTENDED.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)