linux-kernel - Re: [PATCH v3 3/4] ALSA: timer: Introduce virtual userspace-driven timers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bcfd160-8c6a-4a1f-807c-f76e7f069b49@perex.cz>
Date: Tue, 6 Aug 2024 15:11:39 +0200
From: Jaroslav Kysela <perex@...ex.cz>
To: Ivan Orlov <ivan.orlov0322@...il.com>, tiwai@...e.com, corbet@....net,
 broonie@...nel.org, shuah@...nel.org
Cc: linux-kselftest@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
 christophe.jaillet@...adoo.fr, aholzinger@....de
Subject: Re: [PATCH v3 3/4] ALSA: timer: Introduce virtual userspace-driven
 timers

On 06. 08. 24 14:52, Ivan Orlov wrote:
> Implement two ioctl calls in order to support virtual userspace-driven
> ALSA timers.

...

> +struct snd_utimer_info {
> +	/*
> +	 * To pretend being a normal timer, we need to know the frame rate and
> +	 * the period size in frames.
> +	 */
> +	__u64 frame_rate;
> +	__u64 period_size;

There should be just one timer resolution in ns member (like in struct 
snd_timer_ginfo - not frame/period members here - it's too specific). The 
resolution can be calculated in the user space from the rate and period size.

Also naming - the timer API uses snd_timer prefix for structures, thus 
snd_timer_uinfo should be more appropriate.

					Jaroslav

-- 
Jaroslav Kysela <perex@...ex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.