linux-kernel - Re: [PATCH v3 4/4] selftests: ALSA: Cover userspace-driven timers with test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a6be66bd-1133-48aa-b892-48b132e7a0c2@gmail.com>
Date: Tue, 6 Aug 2024 14:53:06 +0100
From: Ivan Orlov <ivan.orlov0322@...il.com>
To: Mark Brown <broonie@...nel.org>
Cc: perex@...ex.cz, tiwai@...e.com, corbet@....net, shuah@...nel.org,
 linux-kselftest@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
 christophe.jaillet@...adoo.fr, aholzinger@....de
Subject: Re: [PATCH v3 4/4] selftests: ALSA: Cover userspace-driven timers
 with test

On 8/6/24 14:04, Mark Brown wrote:
> On Tue, Aug 06, 2024 at 01:52:43PM +0100, Ivan Orlov wrote:
> 
>> -TEST_GEN_PROGS := mixer-test pcm-test test-pcmtest-driver
>> +TEST_GEN_PROGS := mixer-test pcm-test utimer-test test-pcmtest-driver global-timer
> 
> This is adding the timer timer tests as standard kselftests to be run by
> the wrapper script...
> 
>> index 000000000000..c15ec0ba851a
>> --- /dev/null
>> +++ b/tools/testing/selftests/alsa/global-timer.c
> 
>> +int main(int argc, char *argv[])
>> +{
>> +	int device, subdevice, timeout;
>> +
>> +	if (argc < 4) {
>> +		perror("Usage: %s <device> <subdevice> <timeout>");
>> +		return EXIT_FAILURE;
>> +	}
> 
> ...but this requires specific arguments to be run which the kselftest
> runner won't supply.  I'd expect it to be a good default to enumerate
> and test every possible device and generate a test for each.  However it
> looks like this is really intended not as a standalone test but rather
> as something run from within utimer-test, in that case it should be a
> TEST_GEN_PROGS_EXTENDED.

Hi Mark,

Yes, the 'global-timer' application is not a standalone test and it 
should be ran by 'utimer-test'. I had to extract the timer-binding 
functionality into a different application as we can't have 
'sound/asound.h' and 'alsa/asoundlib.h' in single source due to some 
declarations overlap problems.

I'll move the 'global-timer' tool into the TEST_GEN_PROGS_EXTENDED list.

Thank you so much for the review!

-- 
Kind regards,
Ivan Orlov