[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c5624841-fa50-4bd1-841f-071bef166fd8@gmail.com>
Date: Tue, 6 Aug 2024 14:56:50 +0100
From: Ivan Orlov <ivan.orlov0322@...il.com>
To: Jaroslav Kysela <perex@...ex.cz>, tiwai@...e.com, corbet@....net,
broonie@...nel.org, shuah@...nel.org
Cc: linux-kselftest@...r.kernel.org, linux-doc@...r.kernel.org,
linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
christophe.jaillet@...adoo.fr, aholzinger@....de
Subject: Re: [PATCH v3 3/4] ALSA: timer: Introduce virtual userspace-driven
timers
On 8/6/24 14:11, Jaroslav Kysela wrote:
> On 06. 08. 24 14:52, Ivan Orlov wrote:
>> Implement two ioctl calls in order to support virtual userspace-driven
>> ALSA timers.
>
> ...
>
Hi Jaroslav,
>> +struct snd_utimer_info {
>> + /*
>> + * To pretend being a normal timer, we need to know the frame
>> rate and
>> + * the period size in frames.
>> + */
>> + __u64 frame_rate;
>> + __u64 period_size;
>
> There should be just one timer resolution in ns member (like in struct
> snd_timer_ginfo - not frame/period members here - it's too specific).
> The resolution can be calculated in the user space from the rate and
> period size.
>
Ah, yes, I agree... Also, it should help us to avoid complex
calculations and sanity checks in the kernel space. I'll replace these
two fields with 'resolution' field in V4, thanks!
> Also naming - the timer API uses snd_timer prefix for structures, thus
> snd_timer_uinfo should be more appropriate.
>
Alright, I'll rename the structure.
Thank you so much for the review!
--
Kind regards,
Ivan Orlov
Powered by blists - more mailing lists