linux-kernel - Re: [PATCH v2] arm64: dts: rockchip: add rfkill node for M.2 E wifi on orangepi-5-plus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <q7db4syvuz3qsssgznjnwujm25gzmxdf7n5dzjhmmwsaxssk5e@5ecftp23wc7p>
Date: Wed, 7 Aug 2024 20:28:54 +0300
From: Florian Klink <flokli@...kli.de>
To: Heiko Stübner <heiko@...ech.de>
Cc: Dragan Simic <dsimic@...jaro.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Sebastian Reichel <sebastian.reichel@...labora.com>, Kever Yang <kever.yang@...k-chips.com>, 
	Muhammed Efe Cetin <efectn@...tonmail.com>, FUKAUMI Naoki <naoki@...xa.com>, 
	Tamás Szűcs <tszucs@...tonmail.ch>, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] arm64: dts: rockchip: add rfkill node for M.2 E wifi
 on orangepi-5-plus

Hey,

On Wed, Aug 07, 2024 at 07:17:49PM GMT, Heiko Stübner wrote:
>Hi Florian,
>
>Am Mittwoch, 7. August 2024, 19:15:03 CEST schrieb Dragan Simic:
>> On 2024-08-07 19:00, Florian Klink wrote:
>> > This follows the same logic as 82d40b141a4c ("arm64: dts: rockchip: add
>> > rfkill node for M.2 Key E WiFi on rock-5b").
>> >
>> > On the orangepi-5-plus, there's also a GPIO pin connecting the WiFi
>> > enable signal inside the M.2 Key E slot.
>> >
>> > The exact GPIO PIN can be validated in the Armbian rk-5.10-rkr4 kernel
>> > rk3588-orangepi-5-plus.dtsi file [1], which contains a `wifi_disable`
>> > node referencing RK_PC4 on &gpio0.
>> >
>> > Signed-off-by: Florian Klink <flokli@...kli.de>
>> > Tested-by: Florian Klink <flokli@...kli.de>
>> > Link:
>> > https://github.com/armbian/linux-rockchip/blob/9fbe23c9da24f236c6009f42d3f02c1ffb84c169/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts
>> > [1]
>>
>> Unfortunately, this isn't how the "Link: ..." tag is to be used, or how
>> a reference is to be provided.  Please see the patch submission linked
>> below for a correct example of providing links as references.
>>
>> https://lore.kernel.org/linux-rockchip/4449f7d4eead787308300e2d1d37b88c9d1446b2.1717308862.git.dsimic@manjaro.org/T/#u
>
>please also don't post v2 patches as replies to v1.
>Instead start a new mail thread please.
>
>A lot of tooling cannot really find the correct version in such
>multiversion threads.

sorry for the noise. I sent a v3, addressing the requested changes, as a
new thread.

Somewhat offtopic for this patch, but it'd be great if
process/submitting-patches.html could include:

  - A mention of the kernel quotation style for commit ids and subjects
	 and how to produce them
  - A styleguide for how to link to references
  - An active discouragement from using --in-reply-to for v2 (which
	 differs from what `git send-email` proposes).

Florian