linux-kernel - Re: [PATCH v2 0/3] Fixes for memmap accounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66b3fc8d39391_2657d52945e@dwillia2-xfh.jf.intel.com.notmuch>
Date: Wed, 7 Aug 2024 16:00:29 -0700
From: Dan Williams <dan.j.williams@...el.com>
To: Pasha Tatashin <pasha.tatashin@...een.com>, <akpm@...ux-foundation.org>,
	<linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>,
	<cerasuolodomenico@...il.com>, <hannes@...xchg.org>,
	<j.granados@...sung.com>, <lizhijian@...itsu.com>, <muchun.song@...ux.dev>,
	<nphamcs@...il.com>, <rientjes@...gle.com>, <rppt@...nel.org>,
	<souravpanda@...gle.com>, <vbabka@...e.cz>, <willy@...radead.org>,
	<linux-cxl@...r.kernel.org>
Subject: Re: [PATCH v2 0/3] Fixes for memmap accounting

[ add linux-cxl ]

Pasha Tatashin wrote:
> Memmap accounting provides us with observability of how much memory is
> used for per-page metadata: i.e. "struct page"'s and "struct page_ext".
> It also provides with information of how much was allocated using
> boot allocator (i.e. not part of MemTotal), and how much was allocated
> using buddy allocated (i.e. part of MemTotal).
> 
> This small series fixes a few problems that were discovered with the
> original patch.
> 
> v1: https://lore.kernel.org/all/20240806221454.1971755-1-pasha.tatashin@soleen.com
> Changes:
> 	- Added patch "mm: don't account memmap on failure"
> 	- Changed from using nid in hot-remove functions to non-pernode
> 	  system-wide accounting for memmap data.
> 
> Pasha Tatashin (3):
>   mm: update the memmap stat before page is freed
>   mm: don't account memmap on failure
>   mm: don't account memmap per node

Hi Pasha,

Thanks for jumping on this debug!

We almost missed these. Can you update your scripts to auto-cc folks on the
Reported-by line, and optionally include the lists where the report originated
next time?

This is looking good from my tests, you can add:

Tested-by: Dan Williams <dan.j.williams@...el.com>

...but I still want to take a look at some of the implementation choices.